Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 189263006: Fix button color on Android to match Ash (Closed)

Created:
6 years, 9 months ago by keishi
Modified:
6 years, 9 months ago
Reviewers:
tkent
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr.
Visibility:
Public.

Description

Fix button color on Android to match Ash buttons and <select> buttons were darker on Android than on Ash. BUG=351275 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169934

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M Source/core/rendering/RenderThemeChromiumAndroid.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumAndroid.cpp View 1 2 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
keishi
6 years, 9 months ago (2014-03-12 02:16:56 UTC) #1
tkent
lgtm. I understand it's hard to detect what layout tests will be affected and add ...
6 years, 9 months ago (2014-03-12 02:31:50 UTC) #2
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 9 months ago (2014-03-12 02:31:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/189263006/40001
6 years, 9 months ago (2014-03-12 02:31:58 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-12 02:32:19 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit, linux_blink_rel
6 years, 9 months ago (2014-03-12 02:32:20 UTC) #6
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 9 months ago (2014-03-12 02:33:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/189263006/40001
6 years, 9 months ago (2014-03-12 02:33:15 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-12 05:44:51 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel
6 years, 9 months ago (2014-03-12 05:44:52 UTC) #10
keishi
The CQ bit was checked by keishi@chromium.org
6 years, 9 months ago (2014-03-25 11:05:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/189263006/40001
6 years, 9 months ago (2014-03-25 11:05:46 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-25 12:04:25 UTC) #13
Message was sent while issue was closed.
Change committed as 169934

Powered by Google App Engine
This is Rietveld 408576698