Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: sdk/lib/io/file.dart

Issue 1892623002: Fixes leak of native File objects. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/js_runtime/lib/io_patch.dart ('k') | sdk/lib/io/file_impl.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/io/file.dart
diff --git a/sdk/lib/io/file.dart b/sdk/lib/io/file.dart
index d9b2cb41c5b80f2176f75fb950c5cb401e163cc7..4ac4486f6795ecda472864baa1e090da77d8b8da 100644
--- a/sdk/lib/io/file.dart
+++ b/sdk/lib/io/file.dart
@@ -751,7 +751,7 @@ abstract class RandomAccessFile {
* already unlocked".
*/
Future<RandomAccessFile> lock(
- [FileLock mode = FileLock.EXCLUSIVE, int start = 0, int end]);
+ [FileLock mode = FileLock.EXCLUSIVE, int start = 0, int end = -1]);
/**
* Synchronously locks the file or part of the file.
@@ -784,7 +784,8 @@ abstract class RandomAccessFile {
* already unlocked".
*
*/
- void lockSync([FileLock mode = FileLock.EXCLUSIVE, int start = 0, int end]);
+ void lockSync(
+ [FileLock mode = FileLock.EXCLUSIVE, int start = 0, int end = -1]);
/**
* Unlocks the file or part of the file.
@@ -800,7 +801,7 @@ abstract class RandomAccessFile {
*
* See [lock] for more details.
*/
- Future<RandomAccessFile> unlock([int start = 0, int end]);
+ Future<RandomAccessFile> unlock([int start = 0, int end = -1]);
/**
* Synchronously unlocks the file or part of the file.
@@ -816,7 +817,7 @@ abstract class RandomAccessFile {
*
* See [lockSync] for more details.
*/
- void unlockSync([int start = 0, int end]);
+ void unlockSync([int start = 0, int end = -1]);
/**
* Returns a human-readable string for this RandomAccessFile instance.
« no previous file with comments | « sdk/lib/_internal/js_runtime/lib/io_patch.dart ('k') | sdk/lib/io/file_impl.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698