runtime/bin/main.cc - Issue 1892623002: Fixes leak of native File objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/main.cc

Issue 1892623002: Fixes leak of native File objects. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Address comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/main.cc

diff --git a/runtime/bin/main.cc b/runtime/bin/main.cc

index 742754595501bfcfee629c9414f9da91d0e9ddfc..d0d92b2a08ee226c8a6796da2cadb0f3b4e62208 100644

--- a/runtime/bin/main.cc

+++ b/runtime/bin/main.cc

@@ -1099,7 +1099,7 @@ static void WriteSnapshotFile(const char* snapshot_directory,

"Unable to open file %s for writing snapshot\n",

qualified_filename);

}

- delete file;

+ file->Release();

if (concat != NULL) {

delete concat;

}

« no previous file with comments | « runtime/bin/io_natives.cc ('k') | sdk/lib/_internal/js_runtime/lib/io_patch.dart » ('j') | no next file with comments »