runtime/bin/gen_snapshot.cc - Issue 1892623002: Fixes leak of native File objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/gen_snapshot.cc

Issue 1892623002: Fixes leak of native File objects. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Address comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/gen_snapshot.cc

diff --git a/runtime/bin/gen_snapshot.cc b/runtime/bin/gen_snapshot.cc

index 258b9a72850901574b3a6519cbec3c488849dc25..448fd28cbddf8c0d8ffb0e6d37521bf239697703 100644

--- a/runtime/bin/gen_snapshot.cc

+++ b/runtime/bin/gen_snapshot.cc

@@ -214,7 +214,7 @@ static void WriteSnapshotFile(const char* filename,

if (!file->WriteFully(buffer, size)) {

Log::PrintErr("Error: Failed to write snapshot file.\n\n");

}

- delete file;

+ file->Release();

}

« no previous file with comments | « runtime/bin/file_win.cc ('k') | runtime/bin/io_natives.cc » ('j') | no next file with comments »