runtime/bin/dartutils.cc - Issue 1892623002: Fixes leak of native File objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/dartutils.cc

Issue 1892623002: Fixes leak of native File objects. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Address comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/dartutils.cc

diff --git a/runtime/bin/dartutils.cc b/runtime/bin/dartutils.cc

index 39f147a5a6991afe85f385b44e34ec45d636dfba..396b116fdd6d6dadb4b3fff83cba50a42d8796e2 100644

--- a/runtime/bin/dartutils.cc

+++ b/runtime/bin/dartutils.cc

@@ -222,7 +222,8 @@ void DartUtils::WriteFile(const void* buffer,

void DartUtils::CloseFile(void* stream) {

- delete reinterpret_cast<File*>(stream);

+ File* file = reinterpret_cast<File*>(stream);

+ file->Release();

}

« no previous file with comments | « no previous file | runtime/bin/file.h » ('j') | no next file with comments »