Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Side by Side Diff: runtime/bin/file_test.cc

Issue 1892623002: Fixes leak of native File objects. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/bin/file_patch.dart ('k') | runtime/bin/file_unsupported.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "bin/file.h" 5 #include "bin/file.h"
6 #include "platform/assert.h" 6 #include "platform/assert.h"
7 #include "platform/globals.h" 7 #include "platform/globals.h"
8 #include "vm/unit_test.h" 8 #include "vm/unit_test.h"
9 9
10 namespace dart { 10 namespace dart {
(...skipping 14 matching lines...) Expand all
25 TEST_CASE(Read) { 25 TEST_CASE(Read) {
26 const char* kFilename = GetFileName("runtime/bin/file_test.cc"); 26 const char* kFilename = GetFileName("runtime/bin/file_test.cc");
27 File* file = File::Open(kFilename, File::kRead); 27 File* file = File::Open(kFilename, File::kRead);
28 EXPECT(file != NULL); 28 EXPECT(file != NULL);
29 char buffer[16]; 29 char buffer[16];
30 buffer[0] = '\0'; 30 buffer[0] = '\0';
31 EXPECT(file->ReadFully(buffer, 13)); // ReadFully returns true. 31 EXPECT(file->ReadFully(buffer, 13)); // ReadFully returns true.
32 buffer[13] = '\0'; 32 buffer[13] = '\0';
33 EXPECT_STREQ("// Copyright ", buffer); 33 EXPECT_STREQ("// Copyright ", buffer);
34 EXPECT(!file->WriteByte(1)); // Cannot write to a read-only file. 34 EXPECT(!file->WriteByte(1)); // Cannot write to a read-only file.
35 delete file; 35 file->Release();
36 } 36 }
37 37
38 38
39 TEST_CASE(FileLength) { 39 TEST_CASE(FileLength) {
40 const char* kFilename = 40 const char* kFilename =
41 GetFileName("runtime/tests/vm/data/fixed_length_file"); 41 GetFileName("runtime/tests/vm/data/fixed_length_file");
42 File* file = File::Open(kFilename, File::kRead); 42 File* file = File::Open(kFilename, File::kRead);
43 EXPECT(file != NULL); 43 EXPECT(file != NULL);
44 EXPECT_EQ(42, file->Length()); 44 EXPECT_EQ(42, file->Length());
45 delete file; 45 file->Release();
46 } 46 }
47 47
48 48
49 TEST_CASE(FilePosition) { 49 TEST_CASE(FilePosition) {
50 char buf[42]; 50 char buf[42];
51 const char* kFilename = 51 const char* kFilename =
52 GetFileName("runtime/tests/vm/data/fixed_length_file"); 52 GetFileName("runtime/tests/vm/data/fixed_length_file");
53 File* file = File::Open(kFilename, File::kRead); 53 File* file = File::Open(kFilename, File::kRead);
54 EXPECT(file != NULL); 54 EXPECT(file != NULL);
55 EXPECT(file->ReadFully(buf, 12)); 55 EXPECT(file->ReadFully(buf, 12));
56 EXPECT_EQ(12, file->Position()); 56 EXPECT_EQ(12, file->Position());
57 EXPECT(file->ReadFully(buf, 6)); 57 EXPECT(file->ReadFully(buf, 6));
58 EXPECT_EQ(18, file->Position()); 58 EXPECT_EQ(18, file->Position());
59 delete file; 59 file->Release();
60 } 60 }
61 61
62 } // namespace bin 62 } // namespace bin
63 } // namespace dart 63 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/bin/file_patch.dart ('k') | runtime/bin/file_unsupported.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698