Chromium Code Reviews| Index: chrome/common/extensions/api/passwords_private.idl |
| diff --git a/chrome/common/extensions/api/passwords_private.idl b/chrome/common/extensions/api/passwords_private.idl |
| index 1b1d0413119f3cc7024cac32f34689933874576f..65a9012f262855da6c299b9d7679bb4246e18c58 100644 |
| --- a/chrome/common/extensions/api/passwords_private.idl |
| +++ b/chrome/common/extensions/api/passwords_private.idl |
| @@ -39,6 +39,9 @@ namespace passwordsPrivate { |
| DOMString plaintextPassword; |
| }; |
| + callback passwordListCallback = void(PasswordUiEntry[] entries); |
|
Devlin
2016/04/20 22:32:52
nitty nit: prefer PasswordListCallback (start with
hcarmona
2016/04/20 23:10:58
Done.
|
| + callback exceptionListCallback = void(DOMString[] exceptions); |
| + |
| interface Functions { |
| // Removes the saved password corresponding to |loginPair|. If no saved |
| // password for this pair exists, this function is a no-op. |
| @@ -56,10 +59,21 @@ namespace passwordsPrivate { |
| // some operating systems, this call may result in an OS-level |
| // reauthentication. Once the password has been fetched, it will be returned |
| // via the onPlaintextPasswordRetrieved event. |
| + // TODO(hcarmona): Investigate using a callback for consistency. |
| // |
| // |loginPair|: The LoginPair corresponding to the entry whose password |
| // is to be returned. |
| static void requestPlaintextPassword(LoginPair loginPair); |
| + |
| + // Returns the list of saved passwords using |callback|. |
|
Devlin
2016/04/20 22:32:52
nit: remove "using |callback|". It's clear from t
hcarmona
2016/04/20 23:10:58
Done.
|
| + // |
|
Devlin
2016/04/20 22:32:52
nit: remove
hcarmona
2016/04/20 23:10:58
Done.
|
| + // |callback|: Called with the list of saved passwords. |
| + static void getSavedPasswordList(passwordListCallback callback); |
| + |
| + // Returns the list of password exceptions using |callback|. |
| + // |
|
Devlin
2016/04/20 22:32:52
(Same nits as above)
hcarmona
2016/04/20 23:10:58
Done.
|
| + // |callback|: Called with the list of password exceptions. |
| + static void getPasswordExceptionList(exceptionListCallback callback); |
| }; |
| interface Events { |