Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9393)

Unified Diff: chrome/common/extensions/api/passwords_private.idl

Issue 1892613006: Add functions to the passwords private api that update the lists. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add callback Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/passwords_private.idl
diff --git a/chrome/common/extensions/api/passwords_private.idl b/chrome/common/extensions/api/passwords_private.idl
index 1b1d0413119f3cc7024cac32f34689933874576f..3c2546f92a545f098bc33f7ef83c79fc49e5d116 100644
--- a/chrome/common/extensions/api/passwords_private.idl
+++ b/chrome/common/extensions/api/passwords_private.idl
@@ -39,6 +39,9 @@ namespace passwordsPrivate {
DOMString plaintextPassword;
};
+ callback passwordListCallback = void(PasswordUiEntry[] entries);
+ callback exceptionListCallback = void(DOMString[] exceptions);
+
interface Functions {
// Removes the saved password corresponding to |loginPair|. If no saved
// password for this pair exists, this function is a no-op.
@@ -56,10 +59,21 @@ namespace passwordsPrivate {
// some operating systems, this call may result in an OS-level
// reauthentication. Once the password has been fetched, it will be returned
// via the onPlaintextPasswordRetrieved event.
+ // TODO(hcarmona): Make this use a callback for consistency.
stevenjb 2016/04/19 20:59:17 This is a bit more complicated. I don't remember t
hcarmona 2016/04/19 23:07:45 Sounds good. I haven't investigated this yet, I no
//
// |loginPair|: The LoginPair corresponding to the entry whose password
// is to be returned.
static void requestPlaintextPassword(LoginPair loginPair);
+
+ // Returns the list of saved passwords using |callback|.
+ //
+ // |callback|: Called with the list of saved passwords.
+ static void requestSavedPasswordList(passwordListCallback callback);
stevenjb 2016/04/19 20:59:17 I think these should now be 'get' instead of 'requ
hcarmona 2016/04/19 23:07:45 Done.
+
+ // Returns the list of password exceptions using |callback|.
+ //
+ // |callback|: Called with the list of password exceptions.
+ static void requestPasswordExceptionList(exceptionListCallback callback);
};
interface Events {

Powered by Google App Engine
This is Rietveld 408576698