content/browser/accessibility/browser_accessibility_manager_win.cc - Issue 1892593003: Prevent child frames from sending bad accessibility events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_manager_win.cc

Issue 1892593003: Prevent child frames from sending bad accessibility events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_manager.cc ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_manager_win.cc

diff --git a/content/browser/accessibility/browser_accessibility_manager_win.cc b/content/browser/accessibility/browser_accessibility_manager_win.cc

index eb9a2e4db2101e7eec5e037241d0f0230fbb19f2..99a01bbd480177407f691c0558c27caf99196c72 100644

--- a/content/browser/accessibility/browser_accessibility_manager_win.cc

+++ b/content/browser/accessibility/browser_accessibility_manager_win.cc

@@ -89,7 +89,8 @@ IAccessible* BrowserAccessibilityManagerWin::GetParentIAccessible() {

void BrowserAccessibilityManagerWin::MaybeCallNotifyWinEvent(

DWORD event, BrowserAccessibility* node) {

- BrowserAccessibilityDelegate* delegate = GetDelegateFromRootManager();

+ BrowserAccessibilityDelegate* delegate =

+ node->manager()->GetDelegateFromRootManager();

if (!delegate) {

// This line and other LOG(WARNING) lines are temporary, to debug

// flaky failures in DumpAccessibilityEvent* tests.