Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1892593002: Fix HistoryEntry corruption when commit isn't for provisional entry (try #2). (Closed)

Created:
4 years, 8 months ago by Charlie Reis
Modified:
4 years, 8 months ago
Reviewers:
Nate Chapin, alexmos
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Fix HistoryEntry corruption when commit isn't for provisional entry (try #2). BUG=597322, 600238 TEST=See bug for repro steps. TBR=japhet,alexmos NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1848813005 Cr-Commit-Position: refs/heads/master@{#386785} (cherry picked from commit 82500315884357312b3caafb49d347ef011c296f)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -1 line) Patch
M content/browser/frame_host/navigation_controller_impl_browsertest.cc View 2 chunks +146 lines, -0 lines 0 comments Download
M content/renderer/history_controller.cc View 1 chunk +30 lines, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
Charlie Reis
Merging to M51.
4 years, 8 months ago (2016-04-14 20:14:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1892593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1892593002/1
4 years, 8 months ago (2016-04-14 20:15:00 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 20:16:23 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698