Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 1892573003: cc: Disable image hijack canvas when tiles don't have images. (Closed)

Created:
4 years, 8 months ago by vmpstr
Modified:
4 years, 8 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Disable image hijack canvas when tiles don't have images. This patch disables the image hijack canvas whenever the tile being rasterized does not have images. This also deletes a function that is no longer being used. R=enne CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/8623c9c8b645083ce4951054f117d1f3d03083c2 Cr-Commit-Position: refs/heads/master@{#387429}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -10 lines) Patch
M cc/playback/display_item_list.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/playback/display_item_list.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/playback/raster_source.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/tiles/tile_manager.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
vmpstr
Please take a look.
4 years, 8 months ago (2016-04-14 20:01:00 UTC) #2
enne (OOO)
lgtm
4 years, 8 months ago (2016-04-14 20:17:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1892573003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1892573003/1
4 years, 8 months ago (2016-04-14 20:19:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 21:21:32 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 21:23:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8623c9c8b645083ce4951054f117d1f3d03083c2
Cr-Commit-Position: refs/heads/master@{#387429}

Powered by Google App Engine
This is Rietveld 408576698