Issue 1892553003: dont reuse the analysis context across worker requests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1892553003: dont reuse the analysis context across worker requests (Closed)

Created:
4 years, 8 months ago by jakemac

Modified:
4 years, 8 months ago

Reviewers:
Jennifer Messerly

CC:
dev-compiler+reviews_dartlang.org, vsm

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -33 lines)			Patch
M	lib/src/compiler/command.dart	View	1	3 chunks	+15 lines, -15 lines	0 comments	Download
D	test/worker/hello_world.dart	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	test/worker/worker_test.dart	View		4 chunks	+29 lines, -11 lines	0 comments	Download

Total messages: 5 (2 generated)

jakemac

Multiple builds were using cached file contents since the ModuleCompiler was keeping around an AnalysisContext. ...

4 years, 8 months ago (2016-04-15 14:25:36 UTC) #2

jakemac

4 years, 8 months ago (2016-04-15 17:54:11 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
64c0e9f570a670d6a616589e15d6ed555f8a3e64 (presubmit successful).