Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1892543002:
Make sure the color profile propagetes through the system. (Closed)
DescriptionMake sure the color profile propagetes through the system.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1892543002
Committed: https://skia.googlesource.com/skia/+/149b47fec73ce945ef26463a3092bad5569b6a53
Patch Set 1 #Patch Set 2 : Formatting. #
Total comments: 6
Patch Set 3 : change to makeWH call #Messages
Total messages: 22 (9 generated)
Description was changed from ========== Make sure the color profile propagetes through the system. BUG=skia: ========== to ========== Make sure the color profile propagetes through the system. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Formatting.
The CQ bit was checked by herb@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1892543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1892543002/20001
Description was changed from ========== Make sure the color profile propagetes through the system. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Make sure the color profile propagetes through the system. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
herb@google.com changed reviewers: + brianosman@google.com, msarett@google.com
mtklein@google.com changed reviewers: + mtklein@google.com
https://codereview.chromium.org/1892543002/diff/20001/src/core/SkBitmap.cpp File src/core/SkBitmap.cpp (right): https://codereview.chromium.org/1892543002/diff/20001/src/core/SkBitmap.cpp#n... src/core/SkBitmap.cpp:750: dst.setInfo(SkImageInfo::Make(subset.width(), subset.height(), This is probably a good place to be using SkImageInfo::makeWH(). https://codereview.chromium.org/1892543002/diff/20001/src/core/SkBitmap.cpp#n... src/core/SkBitmap.cpp:767: dst.setInfo(SkImageInfo::Make(r.width(), r.height(), this->colorType(), Ditto.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
reed@google.com changed reviewers: + reed@google.com
https://codereview.chromium.org/1892543002/diff/20001/src/core/SkBitmap.cpp File src/core/SkBitmap.cpp (right): https://codereview.chromium.org/1892543002/diff/20001/src/core/SkBitmap.cpp#n... src/core/SkBitmap.cpp:750: dst.setInfo(SkImageInfo::Make(subset.width(), subset.height(), On 2016/04/14 19:36:33, mtklein wrote: > This is probably a good place to be using SkImageInfo::makeWH(). +1
separate from this CL, I might try hiding the default-arg in imageinfo, to catch (at least in our code) places where we've forgotten the profile.
change to makeWH call
https://codereview.chromium.org/1892543002/diff/20001/src/core/SkBitmap.cpp File src/core/SkBitmap.cpp (right): https://codereview.chromium.org/1892543002/diff/20001/src/core/SkBitmap.cpp#n... src/core/SkBitmap.cpp:750: dst.setInfo(SkImageInfo::Make(subset.width(), subset.height(), On 2016/04/14 19:36:33, mtklein wrote: > This is probably a good place to be using SkImageInfo::makeWH(). Done. https://codereview.chromium.org/1892543002/diff/20001/src/core/SkBitmap.cpp#n... src/core/SkBitmap.cpp:750: dst.setInfo(SkImageInfo::Make(subset.width(), subset.height(), On 2016/04/14 19:36:33, mtklein wrote: > This is probably a good place to be using SkImageInfo::makeWH(). Done. https://codereview.chromium.org/1892543002/diff/20001/src/core/SkBitmap.cpp#n... src/core/SkBitmap.cpp:767: dst.setInfo(SkImageInfo::Make(r.width(), r.height(), this->colorType(), On 2016/04/14 19:36:33, mtklein wrote: > Ditto. Done.
lgtm
lgtm
The CQ bit was checked by herb@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1892543002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1892543002/40001
Message was sent while issue was closed.
Description was changed from ========== Make sure the color profile propagetes through the system. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Make sure the color profile propagetes through the system. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/149b47fec73ce945ef26463a3092bad5569b6a53 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/149b47fec73ce945ef26463a3092bad5569b6a53 |
