Change calling convention of CallApiGetterStub to accept the AccessorInfo

src/ic/handler-compiler.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/ic/handler-compiler.h"
 
 #include "src/field-type.h"
 #include "src/ic/call-optimization.h"
 #include "src/ic/ic-inl.h"
 #include "src/ic/ic.h"
@@ skipping 340 matching lines @@
   if (inline_followup) {
     // TODO(368): Compile in the whole chain: all the interceptors in
     // prototypes and ultimate answer.
     GenerateLoadInterceptorWithFollowup(it, reg);
   } else {
     GenerateLoadInterceptor(reg);
   }
   return GetCode(kind(), it->name());
 }
 
+void NamedLoadHandlerCompiler::GenerateLoadCallback(
+    Register reg, Handle<AccessorInfo> callback) {
+  DCHECK(receiver().is(ApiGetterDescriptor::ReceiverRegister()));
+  if (!reg.is(ApiGetterDescriptor::HolderRegister())) {

[Jakob Kummerow, 2016/04/18 13:22:35]

You can drop this line; MacroAssembler::Move contains the dst != src check on
all platforms.

+    __ Move(ApiGetterDescriptor::HolderRegister(), reg);
+  }
+  // The callback is alive if this instruction is executed,
+  // so the weak cell is not cleared and points to data.
+  Handle<WeakCell> cell = isolate()->factory()->NewWeakCell(callback);
+  __ GetWeakValue(ApiGetterDescriptor::CallbackRegister(), cell);
+
+  CallApiGetterStub stub(isolate());
+  __ TailCallStub(&stub);
+}
 
 void NamedLoadHandlerCompiler::GenerateLoadPostInterceptor(
     LookupIterator* it, Register interceptor_reg) {
   Handle<JSObject> real_named_property_holder(it->GetHolder<JSObject>());
 
   Handle<Map> holder_map(holder()->map());
   set_map(holder_map);
   set_holder(real_named_property_holder);
 
   Label miss;
@@ skipping 223 matching lines @@
         LoadICState state = LoadICState(kNoExtraICState);
         cached_stub = LoadDictionaryElementStub(isolate(), state).GetCode();
       }
     }
 
     handlers->Add(cached_stub);
   }
 }
 }  // namespace internal
 }  // namespace v8