Implement ServiceWorker::postMessage() [Chromium]

content/renderer/service_worker/service_worker_script_context.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/service_worker/service_worker_script_context.h"
 
 #include "base/logging.h"
+#include "content/child/webmessageportchannel_impl.h"
 #include "content/common/service_worker/service_worker_messages.h"
 #include "content/renderer/service_worker/embedded_worker_context_client.h"
 #include "ipc/ipc_message.h"
 #include "third_party/WebKit/public/web/WebServiceWorkerContextProxy.h"
 
 namespace content {
 
 ServiceWorkerScriptContext::ServiceWorkerScriptContext(
     EmbeddedWorkerContextClient* embedded_context,
     blink::WebServiceWorkerContextProxy* proxy)
     : embedded_context_(embedded_context),
       proxy_(proxy),
       current_request_id_(kInvalidRequestId) {
 }
 
 ServiceWorkerScriptContext::~ServiceWorkerScriptContext() {}
 
 void ServiceWorkerScriptContext::OnMessageReceived(
     int request_id,
     const IPC::Message& message) {
   DCHECK_EQ(kInvalidRequestId, current_request_id_);
   current_request_id_ = request_id;
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(ServiceWorkerScriptContext, message)
     IPC_MESSAGE_HANDLER(ServiceWorkerMsg_InstallEvent, OnInstallEvent)
     IPC_MESSAGE_HANDLER(ServiceWorkerMsg_FetchEvent, OnFetchEvent)
+    IPC_MESSAGE_HANDLER(ServiceWorkerMsg_Message, OnMessage)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   DCHECK(handled);
   current_request_id_ = kInvalidRequestId;
 }
 
 void ServiceWorkerScriptContext::DidHandleInstallEvent(int request_id) {
   Send(request_id, ServiceWorkerHostMsg_InstallEventFinished());
 }
 
@@ skipping 13 matching lines @@
     int active_version_embedded_worker_id) {
   proxy_->dispatchInstallEvent(current_request_id_);
 }
 
 void ServiceWorkerScriptContext::OnFetchEvent(
     const ServiceWorkerFetchRequest& request) {
   // TODO(falken): Pass in the request.
   proxy_->dispatchFetchEvent(current_request_id_);
 }
 
+void ServiceWorkerScriptContext::OnMessage(
+    const base::string16& message,
+    const std::vector<int>& sent_message_port_ids,
+    const std::vector<int>& new_routing_ids) {
+

[michaeln, 2014/03/17 19:14:03]

nit: blank line not needed

Also i was confused about how current_request_id_ is used in this class and why
it didn't apply to your new OnMessage. Not sure what do to about that,  maybe
something like...

// There is no corresponding message sent back in response..
DCHECK_EQ(kInvalidRequestId, current_request_id_)

[michaeln, 2014/03/17 19:36:46]

On second thought, better doc comments in the .h file about this data member
would have helped a whole lot. Maybe take a stab at adding a doc comment instead
of the code comment here.

// Used for incoming messages from the browser for which an outgoing response
// back to the browser is expected, the id must be sent back with the response.

[jsbell, 2014/03/18 17:20:14]

Good idea, done. (Might end up using that even for postMessage for blob acks.)

+  std::vector<WebMessagePortChannelImpl*> ports;
+  if (!sent_message_port_ids.empty()) {
+    base::MessageLoopProxy* loop_proxy = embedded_context_->main_thread_proxy();
+    ports.resize(sent_message_port_ids.size());
+    for (size_t i = 0; i < sent_message_port_ids.size(); ++i) {
+      ports[i] = new WebMessagePortChannelImpl(
+          new_routing_ids[i], sent_message_port_ids[i], loop_proxy);
+    }
+  }
+
+  proxy_->dispatchMessageEvent(message, ports);
+}
+
 }  // namespace content