Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1892523002: Clean up flags for conditional directives (Closed)

Created:
4 years, 8 months ago by Brian Wilkerson
Modified:
4 years, 8 months ago
Reviewers:
floitsch, pquitslund
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -59 lines) Patch
M pkg/analyzer/lib/src/context/context.dart View 2 chunks +0 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 3 chunks +8 lines, -10 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/options.dart View 2 chunks +2 lines, -8 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 7 chunks +0 lines, -12 lines 0 comments Download
M pkg/analyzer/test/src/task/options_test.dart View 1 chunk +0 lines, -10 lines 0 comments Download
M pkg/analyzer_cli/lib/src/driver.dart View 2 chunks +0 lines, -6 lines 0 comments Download
M pkg/analyzer_cli/lib/src/options.dart View 4 chunks +3 lines, -6 lines 0 comments Download
M pkg/analyzer_cli/test/options_test.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 8 months ago (2016-04-14 18:30:34 UTC) #2
pquitslund
lgtm
4 years, 8 months ago (2016-04-14 18:35:23 UTC) #3
Brian Wilkerson
4 years, 8 months ago (2016-04-14 18:47:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3084ceae830d401d680b38253ff896307a412346 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698