Issue 18925004: modularize the display of diffs for skpdiff

Issue 18925004: modularize the display of diffs for skpdiff (Closed)

Created:
7 years, 5 months ago by Zach Reizner

Modified:
7 years, 5 months ago

Reviewers:
borenet, djsollen

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

modularize the display of diffs for skpdiff R=djsollen@google.com Committed: https://code.google.com/p/skia/source/detail?r=10044

Patch Set 2 : swapimg -> swapImg #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+125 lines, -21 lines)			Patch
M	experimental/skpdiff/diff_viewer.js	View	1	2 chunks	+94 lines, -13 lines	0 comments	Download
M	experimental/skpdiff/viewer.html	View	1	5 chunks	+24 lines, -5 lines	0 comments	Download
M	experimental/skpdiff/viewer_style.css	View		1 chunk	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

djsollen

lgtm with one nit https://codereview.chromium.org/18925004/diff/1/experimental/skpdiff/diff_viewer.js File experimental/skpdiff/diff_viewer.js (right): https://codereview.chromium.org/18925004/diff/1/experimental/skpdiff/diff_viewer.js#newcode7 experimental/skpdiff/diff_viewer.js:7: directive('swapimg', function() { swap_img?

7 years, 5 months ago (2013-07-10 14:44:07 UTC) #2

Zach Reizner

https://codereview.chromium.org/18925004/diff/1/experimental/skpdiff/diff_viewer.js File experimental/skpdiff/diff_viewer.js (right): https://codereview.chromium.org/18925004/diff/1/experimental/skpdiff/diff_viewer.js#newcode7 experimental/skpdiff/diff_viewer.js:7: directive('swapimg', function() { On 2013/07/10 14:44:07, djsollen wrote: > ...

7 years, 5 months ago (2013-07-10 15:00:10 UTC) #3

djsollen

On 2013/07/10 15:00:10, Zach Reizner wrote: > https://codereview.chromium.org/18925004/diff/1/experimental/skpdiff/diff_viewer.js > File experimental/skpdiff/diff_viewer.js (right): > > https://codereview.chromium.org/18925004/diff/1/experimental/skpdiff/diff_viewer.js#newcode7 ...

7 years, 5 months ago (2013-07-10 15:37:22 UTC) #4

Zach Reizner

I was wrong about the dashes. I was just using them wrong in AngularJS. Now ...

7 years, 5 months ago (2013-07-10 15:47:31 UTC) #5

Zach Reizner

7 years, 5 months ago (2013-07-12 13:40:07 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 manually as r10044 (presubmit successful).

Expand Messages | Collapse Messages