SelectionOwner: add support for TIMESTAMP target

ui/events/platform/x11/x11_event_source.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/events/platform/x11/x11_event_source.h"
 
 #include <X11/XKBlib.h>
 #include <X11/Xlib.h>
 
 #include "base/logging.h"
@@ skipping 28 matching lines @@
 
   return true;
 }
 
 }  // namespace
 
 X11EventSource* X11EventSource::instance_ = nullptr;
 
 X11EventSource::X11EventSource(X11EventSourceDelegate* delegate,
                                XDisplay* display)
-    : delegate_(delegate), display_(display), continue_stream_(true) {
+    : delegate_(delegate),
+      display_(display),
+      last_seen_server_time_(CurrentTime),
+      continue_stream_(true) {
   DCHECK(!instance_);
   instance_ = this;
 
   DCHECK(delegate_);
   DCHECK(display_);
   DeviceDataManagerX11::CreateInstance();
   InitializeXkb(display_);
 }
 
 X11EventSource::~X11EventSource() {
@@ skipping 35 matching lines @@
 
 ////////////////////////////////////////////////////////////////////////////////
 // X11EventSource, protected
 
 void X11EventSource::ExtractCookieDataDispatchEvent(XEvent* xevent) {
   bool have_cookie = false;
   if (xevent->type == GenericEvent &&
       XGetEventData(xevent->xgeneric.display, &xevent->xcookie)) {
     have_cookie = true;
   }
+  ExtractTimeFromXEvent(*xevent);
   delegate_->ProcessXEvent(xevent);
   PostDispatchEvent(xevent);
   if (have_cookie)
     XFreeEventData(xevent->xgeneric.display, &xevent->xcookie);
 }
 
 void X11EventSource::PostDispatchEvent(XEvent* xevent) {
   if (xevent->type == GenericEvent &&
       (xevent->xgeneric.evtype == XI_HierarchyChanged ||
        (xevent->xgeneric.evtype == XI_DeviceChanged &&
         static_cast<XIDeviceChangedEvent*>(xevent->xcookie.data)->reason ==
             XIDeviceChange))) {
     ui::UpdateDeviceList();
     hotplug_event_handler_->OnHotplugEvent();
   }
 
   if (xevent->type == EnterNotify &&
       xevent->xcrossing.detail != NotifyInferior &&
       xevent->xcrossing.mode != NotifyUngrab) {
     // Clear stored scroll data
     ui::DeviceDataManagerX11::GetInstance()->InvalidateScrollClasses();
   }
 }
 
+void X11EventSource::ExtractTimeFromXEvent(const XEvent& xevent) {

[dcheng, 2016/04/19 21:56:45]

An alternative was to stash the timestamp off
https://code.google.com/p/chromium/codesearch#chromium/src/ui/events/x/events...,
but that felt more fragile.

One other possibility I considered is to refactor that function so there's a
Time and base::TimeDelta version, but that makes the TimeDelta version a bit
awkward for GenericEvent handling. So in the end, I just forked it.

+  switch (xevent.type) {
+    case KeyPress:
+    case KeyRelease:
+      last_seen_server_time_ = xevent.xkey.time;
+      return;
+    case ButtonPress:
+    case ButtonRelease:
+      last_seen_server_time_ = xevent.xbutton.time;
+      return;
+    case MotionNotify:
+      last_seen_server_time_ = xevent.xmotion.time;
+      return;
+    case EnterNotify:
+    case LeaveNotify:
+      last_seen_server_time_ = xevent.xcrossing.time;
+      return;
+    case PropertyNotify:
+      last_seen_server_time_ = xevent.xproperty.time;
+      return;
+    case SelectionClear:
+      last_seen_server_time_ = xevent.xselectionclear.time;
+      return;
+    case SelectionRequest:
+      last_seen_server_time_ = xevent.xselectionrequest.time;
+      return;
+    case SelectionNotify:
+      last_seen_server_time_ = xevent.xselection.time;
+      return;
+    case GenericEvent:
+      last_seen_server_time_ =

[dcheng, 2016/04/19 21:56:45]

I have no idea how this is safe, but other code seems to do this, e.g.
https://code.google.com/p/chromium/codesearch#chromium/src/ui/events/x/events...

+          static_cast<XIDeviceEvent*>(xevent.xcookie.data)->time;
+      return;
+  }
+}
+
 void X11EventSource::StopCurrentEventStream() {
   continue_stream_ = false;
 }
 
 void X11EventSource::OnDispatcherListChanged() {
   if (!hotplug_event_handler_) {
     hotplug_event_handler_.reset(new X11HotplugEventHandler());
     // Force the initial device query to have an update list of active devices.
     hotplug_event_handler_->OnHotplugEvent();
   }
 }
 
 }  // namespace ui