SelectionOwner: add support for TIMESTAMP target

ui/events/platform/x11/x11_event_source.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/events/platform/x11/x11_event_source.h"
 
 #include <X11/XKBlib.h>
 #include <X11/Xlib.h>
 
 #include "base/logging.h"
@@ skipping 28 matching lines @@
 
   return true;
 }
 
 }  // namespace
 
 X11EventSource* X11EventSource::instance_ = nullptr;
 
 X11EventSource::X11EventSource(X11EventSourceDelegate* delegate,
                                XDisplay* display)
-    : delegate_(delegate), display_(display), continue_stream_(true) {
+    : delegate_(delegate),
+      display_(display),
+      last_seen_server_time_(CurrentTime),
+      continue_stream_(true) {
   DCHECK(!instance_);
   instance_ = this;
 
   DCHECK(delegate_);
   DCHECK(display_);
   DeviceDataManagerX11::CreateInstance();
   InitializeXkb(display_);
 }
 
 X11EventSource::~X11EventSource() {
@@ skipping 35 matching lines @@
 
 ////////////////////////////////////////////////////////////////////////////////
 // X11EventSource, protected
 
 void X11EventSource::ExtractCookieDataDispatchEvent(XEvent* xevent) {
   bool have_cookie = false;
   if (xevent->type == GenericEvent &&
       XGetEventData(xevent->xgeneric.display, &xevent->xcookie)) {
     have_cookie = true;
   }
+  Time event_time = ExtractTimeFromXEvent(*xevent);
+  if (event_time != CurrentTime)
+    last_seen_server_time_ = event_time;
   delegate_->ProcessXEvent(xevent);
   PostDispatchEvent(xevent);
   if (have_cookie)
     XFreeEventData(xevent->xgeneric.display, &xevent->xcookie);
 }
 
 void X11EventSource::PostDispatchEvent(XEvent* xevent) {
   if (xevent->type == GenericEvent &&
       (xevent->xgeneric.evtype == XI_HierarchyChanged ||
        (xevent->xgeneric.evtype == XI_DeviceChanged &&
         static_cast<XIDeviceChangedEvent*>(xevent->xcookie.data)->reason ==
             XIDeviceChange))) {
     ui::UpdateDeviceList();
     hotplug_event_handler_->OnHotplugEvent();
   }
 
   if (xevent->type == EnterNotify &&
       xevent->xcrossing.detail != NotifyInferior &&
       xevent->xcrossing.mode != NotifyUngrab) {
     // Clear stored scroll data
     ui::DeviceDataManagerX11::GetInstance()->InvalidateScrollClasses();
   }
 }
 
+Time X11EventSource::ExtractTimeFromXEvent(const XEvent& xevent) {

[sadrul, 2016/04/20 17:58:43]

This can go in a standalone function in anon namespace.

[dcheng, 2016/04/20 18:55:43]

Done.

+  switch (xevent.type) {
+    case KeyPress:
+    case KeyRelease:
+      return xevent.xkey.time;
+    case ButtonPress:
+    case ButtonRelease:
+      return xevent.xbutton.time;
+    case MotionNotify:
+      return xevent.xmotion.time;
+    case EnterNotify:
+    case LeaveNotify:
+      return xevent.xcrossing.time;
+    case PropertyNotify:
+      return xevent.xproperty.time;
+    case SelectionClear:
+      return xevent.xselectionclear.time;
+    case SelectionRequest:
+      return xevent.xselectionrequest.time;
+    case SelectionNotify:
+      return xevent.xselection.time;
+    case GenericEvent:
+      return static_cast<XIDeviceEvent*>(xevent.xcookie.data)->time;

[sadrul, 2016/04/20 18:01:08]

Also, you should check DeviceDataManagerX11::IsXIDeviceEvent() before casting to
XIDeviceEvent

[dcheng, 2016/04/20 18:55:43]

Done. But as mentioned earlier, other code often doesn't do this (e.g.
https://code.google.com/p/chromium/codesearch#chromium/src/ui/aura/window_tre...).
How is that code safe?

+  }
+  return CurrentTime;
+}
+
 void X11EventSource::StopCurrentEventStream() {
   continue_stream_ = false;
 }
 
 void X11EventSource::OnDispatcherListChanged() {
   if (!hotplug_event_handler_) {
     hotplug_event_handler_.reset(new X11HotplugEventHandler());
     // Force the initial device query to have an update list of active devices.
     hotplug_event_handler_->OnHotplugEvent();
   }
 }
 
 }  // namespace ui