Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1892483003: close the input stream in build_mode tests so they dont hang (Closed)

Created:
4 years, 8 months ago by jakemac
Modified:
4 years, 8 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

close the input stream in build_mode tests so they dont hang R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/d4197b759de30d510b468a0e1fb65dbffb0775ee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M pkg/analyzer_cli/test/build_mode_test.dart View 5 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
jakemac
4 years, 8 months ago (2016-04-14 16:32:28 UTC) #2
Paul Berry
lgtm
4 years, 8 months ago (2016-04-14 17:37:36 UTC) #3
jakemac
4 years, 8 months ago (2016-04-14 17:54:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d4197b759de30d510b468a0e1fb65dbffb0775ee (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698