third_party/WebKit/Source/core/layout/LayoutObject.cpp - Issue 1892473002: Update PaintLayer::needsPaintPhaseXXX flags when add/remove layer on style change

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.cpp

Issue 1892473002: Update PaintLayer::needsPaintPhaseXXX flags when add/remove layer on style change (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp ('k') | third_party/WebKit/Source/core/paint/PaintLayer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutObject.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.cpp b/third_party/WebKit/Source/core/layout/LayoutObject.cpp

index d80c768cf7ce15c604a70082f07d7519a0b6f39b..0c6f807ad672cb735dc2bb633c22be393993eedb 100644

--- a/third_party/WebKit/Source/core/layout/LayoutObject.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutObject.cpp

@@ -352,7 +352,7 @@ void LayoutObject::addChild(LayoutObject* newChild, LayoutObject* beforeChild)

// To avoid the problem altogether, detect early if we're inside a hidden SVG subtree

// and stop creating layers at all for these cases - they're not used anyways.

if (newChild->hasLayer() && !layerCreationAllowedForSubtree())

- toLayoutBoxModelObject(newChild)->layer()->removeOnlyThisLayer();

+ toLayoutBoxModelObject(newChild)->layer()->removeOnlyThisLayerAfterStyleChange();

}

void LayoutObject::removeChild(LayoutObject* oldChild)