Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 1892473002: Update PaintLayer::needsPaintPhaseXXX flags when add/remove layer on style change (Closed)

Created:
4 years, 8 months ago by Xianzhu
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, sof, eae+blinkwatch, leviw+renderwatch, slimming-paint-reviews_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, dshwang, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Update PaintLayer::needsPaintPhaseXXX flags when add/remove layer on style change When addding/removing a layer on style change, we may not do paint invalidation to update the needsPaintPhaseXXX flags, so we need to update the flags manually. In the future, the logic can be simplified by updating the flags during pre-painting tree walk. BUG=598978 Review URL: https://codereview.chromium.org/1862313002 Cr-Commit-Position: refs/heads/master@{#386264} Committed: https://chromium.googlesource.com/chromium/src/+/e921b6e5f7720bee35402813ac14707eb6028480

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -19 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 2 chunks +2 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.h View 3 chunks +10 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 4 chunks +26 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp View 3 chunks +30 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/README.md View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Xianzhu
4 years, 8 months ago (2016-04-14 16:15:38 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e921b6e5f7720bee35402813ac14707eb6028480.

Powered by Google App Engine
This is Rietveld 408576698