Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1892453002: Remove XMLHttpRequest's non-Oilpan support for eager finalization. (Closed)

Created:
4 years, 8 months ago by sof
Modified:
4 years, 8 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove XMLHttpRequest's non-Oilpan support for eager finalization. R= BUG=585328 Committed: https://crrev.com/15f2c1916d1749039679da1242c2d186abae0144 Cr-Commit-Position: refs/heads/master@{#387538}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
please take a look.
4 years, 8 months ago (2016-04-14 16:03:48 UTC) #2
haraken
LGTM
4 years, 8 months ago (2016-04-14 23:37:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1892453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1892453002/1
4 years, 8 months ago (2016-04-15 05:05:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 05:09:08 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 05:10:40 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/15f2c1916d1749039679da1242c2d186abae0144
Cr-Commit-Position: refs/heads/master@{#387538}

Powered by Google App Engine
This is Rietveld 408576698