Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1892443002: Delete breakpad_unittest.isolate (no longer needed) (Closed)

Created:
4 years, 8 months ago by agrieve
Modified:
4 years, 8 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete breakpad_unittest.isolate (no longer needed) As of https://codereview.chromium.org/1854233002/ BUG=none Committed: https://crrev.com/de9a653bdb0fcf0248f405bd7772a3113d39e542 Cr-Commit-Position: refs/heads/master@{#387388}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -49 lines) Patch
D breakpad/breakpad_unittests.isolate View 1 chunk +0 lines, -14 lines 0 comments Download
M breakpad/breakpad_unittests_apk.isolate View 2 chunks +0 lines, -2 lines 0 comments Download
M build/android/pylib/gtest/gtest_test_instance.py View 2 chunks +0 lines, -3 lines 0 comments Download
M testing/buildbot/chromium.android.json View 8 chunks +0 lines, -24 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
agrieve
mark@chromium.org: Please review changes in //breakpad dpranke@chromium.org: Please review changes in elsewhere Note: needs recipe-side ...
4 years, 8 months ago (2016-04-14 15:57:09 UTC) #2
Mark Mentovai
LGTM
4 years, 8 months ago (2016-04-14 16:07:36 UTC) #3
Dirk Pranke
lgtm
4 years, 8 months ago (2016-04-14 16:19:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1892443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1892443002/1
4 years, 8 months ago (2016-04-14 17:10:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 19:15:53 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 19:17:29 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/de9a653bdb0fcf0248f405bd7772a3113d39e542
Cr-Commit-Position: refs/heads/master@{#387388}

Powered by Google App Engine
This is Rietveld 408576698