Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Unified Diff: tools/gn/target.cc

Issue 1892393002: 🐜 GN: Make write_runtime_deps take effect only a target is resolved (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/target.cc
diff --git a/tools/gn/target.cc b/tools/gn/target.cc
index 18c353eac05d3b58732db4b1a2883040be51664a..cac9c644db6cdd31d42669ba053743e5667755be 100644
--- a/tools/gn/target.cc
+++ b/tools/gn/target.cc
@@ -324,6 +324,10 @@ bool Target::OnResolved(Err* err) {
CheckSourcesGenerated();
}
+ if (!write_runtime_deps_output_.value().empty()) {
brettw 2016/04/19 18:29:39 No {}
agrieve 2016/04/20 00:45:02 Done. (a hard habit to break apparently!)
+ g_scheduler->AddWriteRuntimeDepsTarget(this);
+ }
+
return true;
}

Powered by Google App Engine
This is Rietveld 408576698