Issue 189233012: Convert CompositingLayerMapping code to use reference

Issue 189233012: Convert CompositingLayerMapping code to use reference (Closed)

Created:
6 years, 9 months ago by maheshkk

Modified:
6 years, 9 months ago

Reviewers:
Inactive, ojan

CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, abarth-chromium, blink-layers+watch_chromium.org, jchaffraix+rendering, pdr.

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Convert CompositingLayerMapping code to use reference RenderLayer is never null in CompositingLayerMapping and should be reference. Using references safer for caller methods. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168862

Patch Set 1 #

Total comments: 1

Patch Set 2 : Make RenderLayer non-copyable #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+110 lines, -109 lines)			Patch
M	Source/core/rendering/RenderLayer.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/rendering/RenderLayer.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/compositing/CompositedLayerMapping.h	View		4 chunks	+8 lines, -8 lines	0 comments	Download
M	Source/core/rendering/compositing/CompositedLayerMapping.cpp	View		54 chunks	+100 lines, -100 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

Inactive

Looks good with one comment. https://codereview.chromium.org/189233012/diff/1/Source/core/rendering/compositing/CompositedLayerMapping.h File Source/core/rendering/compositing/CompositedLayerMapping.h (right): https://codereview.chromium.org/189233012/diff/1/Source/core/rendering/compositing/CompositedLayerMapping.h#newcode82 Source/core/rendering/compositing/CompositedLayerMapping.h:82: explicit CompositedLayerMapping(RenderLayer&); Please make ...

6 years, 9 months ago (2014-03-10 17:26:51 UTC) #2

maheshkk

Thanks for the review! On 2014/03/10 17:26:51, Chris Dumez wrote: > Looks good with one ...

6 years, 9 months ago (2014-03-10 18:08:05 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mahesh.kk@samsung.com/189233012/20001

6 years, 9 months ago (2014-03-10 18:13:07 UTC) #5

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 9 months ago (2014-03-10 18:33:48 UTC) #6

commit-bot: I haz the power

Try jobs failed on following builders: linux_blink

6 years, 9 months ago (2014-03-10 18:33:50 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mahesh.kk@samsung.com/189233012/20001

6 years, 9 months ago (2014-03-10 19:32:29 UTC) #9

Message was sent while issue was closed.

Change committed as 168862

Expand Messages | Collapse Messages