Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1892273003: Fix HistoryEntry corruption when commit isn't for provisional entry (try #2). (Closed)

Created:
4 years, 8 months ago by Charlie Reis
Modified:
4 years, 8 months ago
Reviewers:
Nate Chapin, alexmos
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Fix HistoryEntry corruption when commit isn't for provisional entry (try #2). (Omit the newly added tests, which won't compile on M50 branch.) BUG=597322, 600238 TEST=See bug for repro steps. TBR=japhet,alexmos NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1848813005 Cr-Commit-Position: refs/heads/master@{#386785} (cherry picked from commit 82500315884357312b3caafb49d347ef011c296f)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M content/renderer/history_controller.cc View 1 chunk +30 lines, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
Charlie Reis
Merging to M50, without the new test (which won't compile there).
4 years, 8 months ago (2016-04-15 22:18:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1892273003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1892273003/1
4 years, 8 months ago (2016-04-15 22:20:06 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 22:24:44 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698