tools/gn/ninja_create_bundle_target_writer.cc - Issue 1892243002: Write a phony target for the top-level directory of a create_bundle target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/ninja_create_bundle_target_writer.cc

Issue 1892243002: Write a phony target for the top-level directory of a create_bundle target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/ninja_create_bundle_target_writer.cc

diff --git a/tools/gn/ninja_create_bundle_target_writer.cc b/tools/gn/ninja_create_bundle_target_writer.cc

index d85f2401ae52209051ba4444d7a6aec51c73a419..e1aec0d260af520189025baa77ddcc2b0e156778 100644

--- a/tools/gn/ninja_create_bundle_target_writer.cc

+++ b/tools/gn/ninja_create_bundle_target_writer.cc

@@ -116,4 +116,12 @@ void NinjaCreateBundleTargetWriter::Run() {

for (const auto& pair : target_->data_deps())

order_only_deps.push_back(pair.ptr->dependency_output_file());

WriteStampForTarget(output_files, order_only_deps);

+ out_ << "build ";

brettw 2016/04/21 19:14:00 Can you write a comment here mentioning what this

Robert Sesek 2016/04/21 21:03:20 Done.

+ path_output_.WriteFile(

+ out_,

+ OutputFile(settings_->build_settings(),

+ target_->bundle_data().GetBundleRootDirOutput(settings_)));

+ out_ << ": phony " << target_->dependency_output_file().value();

+ out_ << std::endl;

}

« tools/gn/bundle_data.cc ('K') | « tools/gn/bundle_data.cc ('k') | tools/gn/ninja_create_bundle_target_writer_unittest.cc » ('j') | no next file with comments »