Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: tools/gn/bundle_data.h

Issue 1892243002: Write a phony target for the top-level directory of a create_bundle target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/gn/bundle_data.cc » ('j') | tools/gn/bundle_data.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef TOOLS_GN_BUNDLE_DATA_H_ 5 #ifndef TOOLS_GN_BUNDLE_DATA_H_
6 #define TOOLS_GN_BUNDLE_DATA_H_ 6 #define TOOLS_GN_BUNDLE_DATA_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 57
58 // Returns the list of outputs as SourceFile. 58 // Returns the list of outputs as SourceFile.
59 void GetOutputsAsSourceFiles( 59 void GetOutputsAsSourceFiles(
60 const Settings* settings, 60 const Settings* settings,
61 SourceFiles* outputs_as_source) const; 61 SourceFiles* outputs_as_source) const;
62 62
63 // Returns the path to the compiled asset catalog. Only valid if 63 // Returns the path to the compiled asset catalog. Only valid if
64 // asset_catalog_sources() is not empty. 64 // asset_catalog_sources() is not empty.
65 SourceFile GetCompiledAssetCatalogPath() const; 65 SourceFile GetCompiledAssetCatalogPath() const;
66 66
67 // Returns the path to the top-level directory of the bundle. This is
68 // based on root_dir(), but since that can be Bundle.app/Contents/ or
69 // any other subpath, this is just the most top-level directory (e.g.,
70 // just Bundle.app/).
71 SourceFile GetBundleRootDirOutput(const Settings* settings) const;
brettw 2016/04/18 20:16:14 Can this return a SourceDir instead? The thing you
Robert Sesek 2016/04/19 15:37:51 Is it acceptable to convert a SourceDir to an Outp
brettw 2016/04/21 19:14:00 I can kind of see that. Can the comment above the
Robert Sesek 2016/04/21 21:03:20 Done.
72
67 // Returns the list of inputs for the compilation of the asset catalog. 73 // Returns the list of inputs for the compilation of the asset catalog.
68 SourceFiles& asset_catalog_sources() { return asset_catalog_sources_; } 74 SourceFiles& asset_catalog_sources() { return asset_catalog_sources_; }
69 const SourceFiles& asset_catalog_sources() const { 75 const SourceFiles& asset_catalog_sources() const {
70 return asset_catalog_sources_; 76 return asset_catalog_sources_;
71 } 77 }
72 78
73 BundleFileRules& file_rules() { return file_rules_; } 79 BundleFileRules& file_rules() { return file_rules_; }
74 const BundleFileRules& file_rules() const { return file_rules_; } 80 const BundleFileRules& file_rules() const { return file_rules_; }
75 81
76 std::string& root_dir() { return root_dir_; } 82 std::string& root_dir() { return root_dir_; }
(...skipping 18 matching lines...) Expand all
95 101
96 // All those values are subdirectories relative to root_build_dir, and apart 102 // All those values are subdirectories relative to root_build_dir, and apart
97 // from root_dir, they are either equal to root_dir_ or subdirectories of it. 103 // from root_dir, they are either equal to root_dir_ or subdirectories of it.
98 std::string root_dir_; 104 std::string root_dir_;
99 std::string resources_dir_; 105 std::string resources_dir_;
100 std::string executable_dir_; 106 std::string executable_dir_;
101 std::string plugins_dir_; 107 std::string plugins_dir_;
102 }; 108 };
103 109
104 #endif // TOOLS_GN_BUNDLE_DATA_H_ 110 #endif // TOOLS_GN_BUNDLE_DATA_H_
OLDNEW
« no previous file with comments | « no previous file | tools/gn/bundle_data.cc » ('j') | tools/gn/bundle_data.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698