Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 1892203002: Revert of SkPDF: PDF/A runtime switch (Closed)

Created:
4 years, 8 months ago by hal.canary
Modified:
4 years, 8 months ago
Reviewers:
tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of SkPDF: PDF/A runtime switch (patchset #1 id:100001 of https://codereview.chromium.org/1891873002/ ) Reason for revert: breaking something. Original issue's description: > SkPDF: PDF/A runtime switch > > TODO: remove gyp variable and modify API in SkDocument.h > > BUG=skia:3110 > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1891873002 > > Committed: https://skia.googlesource.com/skia/+/570f18b43417d73c3fbd113cc0b4258e08b14c82 TBR=tomhudson@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:3110 Committed: https://skia.googlesource.com/skia/+/2299ffaaa1ddf524e35a04bdf6b2ed3cfe202b77

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -168 lines) Patch
M bench/PDFBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/pdf.gyp View 1 chunk +0 lines, -5 lines 0 comments Download
M gyp/pdf.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M src/pdf/SkPDFDocument.h View 3 chunks +4 lines, -5 lines 0 comments Download
M src/pdf/SkPDFDocument.cpp View 8 chunks +165 lines, -152 lines 0 comments Download
M src/pdf/SkPDFMetadata.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/pdf/SkPDFMetadata.cpp View 3 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
hal.canary
Created Revert of SkPDF: PDF/A runtime switch
4 years, 8 months ago (2016-04-15 19:30:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1892203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1892203002/1
4 years, 8 months ago (2016-04-15 19:30:13 UTC) #2
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 19:30:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2299ffaaa1ddf524e35a04bdf6b2ed3cfe202b77

Powered by Google App Engine
This is Rietveld 408576698