Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1892193002: Switch HttpStreamParser fuzzer over to using FuzzedSocket. (Closed)

Created:
4 years, 8 months ago by mmenke
Modified:
4 years, 8 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch HttpStreamParser fuzzer over to using FuzzedSocket. This makes it a lot simpler, since it was basically duplicating FuzzedSocket's logic. BUG=598037 Committed: https://crrev.com/99e0416c6ee1037102c37f8cb0a286ce41405413 Cr-Commit-Position: refs/heads/master@{#387730}

Patch Set 1 #

Total comments: 1

Patch Set 2 : unique_ptr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -84 lines) Patch
M net/http/http_stream_parser_fuzzer.cc View 1 4 chunks +14 lines, -84 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
mmenke
This depends on my IsConnected() fix in the other CL to do anything interesting.
4 years, 8 months ago (2016-04-15 19:05:46 UTC) #2
eroman
lgtm https://codereview.chromium.org/1892193002/diff/1/net/http/http_stream_parser_fuzzer.cc File net/http/http_stream_parser_fuzzer.cc (right): https://codereview.chromium.org/1892193002/diff/1/net/http/http_stream_parser_fuzzer.cc#newcode41 net/http/http_stream_parser_fuzzer.cc:41: new net::FuzzedSocket(data, size, bound_test_net_log.bound())); same comment about std::unique_ptr<>
4 years, 8 months ago (2016-04-15 19:09:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1892193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1892193002/20001
4 years, 8 months ago (2016-04-15 21:53:06 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-15 22:35:24 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 22:37:03 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/99e0416c6ee1037102c37f8cb0a286ce41405413
Cr-Commit-Position: refs/heads/master@{#387730}

Powered by Google App Engine
This is Rietveld 408576698