Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1892183002: Refactor Parsing to remove compiler dependency (Closed)

Created:
4 years, 8 months ago by Harry Terkelsen
Modified:
4 years, 8 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -199 lines) Patch
M pkg/compiler/lib/src/closure.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/common/resolution.dart View 3 chunks +51 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 11 chunks +12 lines, -40 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 22 chunks +24 lines, -23 lines 0 comments Download
M pkg/compiler/lib/src/native/behavior.dart View 8 chunks +10 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/parser/parser_task.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/parser/partial_elements.dart View 8 chunks +8 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/patch_parser.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/class_hierarchy.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/constructors.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 9 chunks +10 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/compiler_test.dart View 1 chunk +11 lines, -48 lines 0 comments Download
M tests/compiler/dart2js/exit_code_test.dart View 4 chunks +7 lines, -7 lines 0 comments Download
M tests/compiler/dart2js/find_my_name_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/parser_helper.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/patch_test.dart View 11 chunks +11 lines, -11 lines 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 5 chunks +6 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/serialization_helper.dart View 4 chunks +9 lines, -13 lines 0 comments Download
M tests/compiler/dart2js/type_checker_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Harry Terkelsen
4 years, 8 months ago (2016-04-15 18:44:12 UTC) #2
Siggi Cherem (dart-lang)
lgtm!
4 years, 8 months ago (2016-04-15 19:20:34 UTC) #3
Harry Terkelsen
Committed patchset #2 (id:20001) manually as ce37fbcb3d0f2be40947c73fbb8715227e5ec557 (presubmit successful).
4 years, 8 months ago (2016-04-15 20:03:08 UTC) #5
Johnni Winther
4 years, 8 months ago (2016-04-19 07:27:40 UTC) #6
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698