Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 1892153002: [Layout API] Convert PrintContext to use Document::layoutViewItem() (Closed)

Created:
4 years, 8 months ago by pilgrim_google
Modified:
4 years, 8 months ago
CC:
blink-reviews, chromium-reviews, dgrogan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Layout API] Convert PrintContext to use Document::layoutViewItem() There were several references to Document::layoutView() which is deprecated by the new layout API. I converted them to use layoutViewItem() instead. No new API methods were required. There are no functional changes. BUG=499321 Committed: https://crrev.com/bf5f64e9761bf0d0227cc40d3c5beca426042c03 Cr-Commit-Position: refs/heads/master@{#388639}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M third_party/WebKit/Source/core/page/PrintContext.cpp View 6 chunks +14 lines, -13 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
pilgrim_google
4 years, 8 months ago (2016-04-15 15:59:46 UTC) #2
eae
LGTM
4 years, 8 months ago (2016-04-17 18:15:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1892153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1892153002/1
4 years, 8 months ago (2016-04-18 01:38:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/206512)
4 years, 8 months ago (2016-04-18 06:35:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1892153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1892153002/1
4 years, 8 months ago (2016-04-20 21:36:33 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/215837)
4 years, 8 months ago (2016-04-20 22:56:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1892153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1892153002/1
4 years, 8 months ago (2016-04-20 23:06:45 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 00:33:59 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:29:18 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf5f64e9761bf0d0227cc40d3c5beca426042c03
Cr-Commit-Position: refs/heads/master@{#388639}

Powered by Google App Engine
This is Rietveld 408576698