Remove disabling of C4267 in 64-bit gn builds

Remove disabling of C4267 in 64-bit gn builds

As part of the VS 2015 port some C4267 warnings (size_t truncated to
smaller type) warnings were globally suppressed. This change removes the
global suppression for 64-bit gn builds and fixes the last few warnings.

The warning suppression remains for 32-bit builds because there are many
warnings there that still need suppression - they were C4244 warnings in
VS 2013 builds.

BUG=440500, 566113
Committed: https://crrev.com/d0ecb3bae2d232c17581eed59fe8aa31fa68f96b
Cr-Commit-Position: refs/heads/master@{#388293}

[brucedawson, 2016-04-18 19:39:31]

Description was changed from

==========
Remove disabling of C4267 in gn builds

As part of the VS 2015 port some C4267 warnings (size_t truncated to
smaller type) warnings were globally suppressed. This change removes the
global suppression and fixes the last few warnings.

BUG=440500,566113
==========

to

==========
Remove disabling of C4267 in gn builds

As part of the VS 2015 port some C4267 warnings (size_t truncated to
smaller type) warnings were globally suppressed. This change removes the
global suppression and fixes the last few warnings.

BUG=440500,566113
==========

[brucedawson, 2016-04-18 19:39:32]

brucedawson@chromium.org changed reviewers:
+ dimich@chromium.org

[brucedawson, 2016-04-18 19:43:29]

brucedawson@chromium.org changed reviewers:
+ rsesek@chromium.org, sky@chromium.org

[brucedawson, 2016-04-18 19:43:29]

This change adds a few casts so that GN builds no longer have to globally
disable C4267 (size_t to smaller truncation).

dimich@ - can you look at gcm_message_cryptographer.cc?
rsesek@ - can you look at upload_list_unittest.cc?
sky@ - can you look at quick_launch_application.cc?

In all cases the casts just make explicit the truncations that have always been
happening.

[sky, 2016-04-18 20:26:35]

LGTM

[Robert Sesek, 2016-04-18 20:27:19]

LGTM

[Dmitry Titov, 2016-04-18 20:37:08]

LGTM

[Dmitry Titov, 2016-04-19 18:15:55]

LGTM again

[brucedawson, 2016-04-19 18:19:29]

On 2016/04/19 18:15:55, Dmitry Titov wrote:
> LGTM again

I had to change BUILD.gn so that the suppression of 4267 remains in 32-bit
builds - this change only removes it in 64-bit builds. That's because if you
truncate a size_t to a uint16_t then that triggers C4244 on 64-bit builds (which
is globally suppressed) but C4267 on 32-bit builds. Until all of those 32-bit
only warnings are fixed we cannot enable C4267 on 32-bit builds. The bug will
remain open until that is addressed.

I didn't realize this initially which is why I needed to tweak BUILD.gn and get
dimich@ to reapprove.

This behavior of these warnings is new in VS 2015.

I'll update the description and land once the try jobs finish.

[brucedawson, 2016-04-19 18:20:41]

Description was changed from

==========
Remove disabling of C4267 in gn builds

As part of the VS 2015 port some C4267 warnings (size_t truncated to
smaller type) warnings were globally suppressed. This change removes the
global suppression and fixes the last few warnings.

BUG=440500,566113
==========

to

==========
Remove disabling of C4267 in 64-bit gn builds

As part of the VS 2015 port some C4267 warnings (size_t truncated to
smaller type) warnings were globally suppressed. This change removes the
global suppression for 64-bit gn builds and fixes the last few warnings.

The warning suppression remains for 32-bit builds because there are many
warnings there that still need suppression - they were C4244 warnings in
VS 2013 builds.

BUG=440500,566113
==========

[brucedawson, 2016-04-19 20:12:17]

The CQ bit was checked by brucedawson@chromium.org

[brucedawson, 2016-04-19 20:12:18]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1892143004/#ps100001
(title: "Fix long line")

[commit-bot: I haz the power, 2016-04-19 20:12:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1892143004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1892143004/100001

[commit-bot: I haz the power, 2016-04-19 20:17:47]

Description was changed from

==========
Remove disabling of C4267 in 64-bit gn builds

As part of the VS 2015 port some C4267 warnings (size_t truncated to
smaller type) warnings were globally suppressed. This change removes the
global suppression for 64-bit gn builds and fixes the last few warnings.

The warning suppression remains for 32-bit builds because there are many
warnings there that still need suppression - they were C4244 warnings in
VS 2013 builds.

BUG=440500,566113
==========

to

==========
Remove disabling of C4267 in 64-bit gn builds

As part of the VS 2015 port some C4267 warnings (size_t truncated to
smaller type) warnings were globally suppressed. This change removes the
global suppression for 64-bit gn builds and fixes the last few warnings.

The warning suppression remains for 32-bit builds because there are many
warnings there that still need suppression - they were C4244 warnings in
VS 2013 builds.

BUG=440500,566113
==========

[commit-bot: I haz the power, 2016-04-19 20:17:48]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-04-22 19:15:41]

Description was changed from

==========
Remove disabling of C4267 in 64-bit gn builds

As part of the VS 2015 port some C4267 warnings (size_t truncated to
smaller type) warnings were globally suppressed. This change removes the
global suppression for 64-bit gn builds and fixes the last few warnings.

The warning suppression remains for 32-bit builds because there are many
warnings there that still need suppression - they were C4244 warnings in
VS 2013 builds.

BUG=440500,566113
==========

to

==========
Remove disabling of C4267 in 64-bit gn builds

As part of the VS 2015 port some C4267 warnings (size_t truncated to
smaller type) warnings were globally suppressed. This change removes the
global suppression for 64-bit gn builds and fixes the last few warnings.

The warning suppression remains for 32-bit builds because there are many
warnings there that still need suppression - they were C4244 warnings in
VS 2013 builds.

BUG=440500,566113

Committed: https://crrev.com/d0ecb3bae2d232c17581eed59fe8aa31fa68f96b
Cr-Commit-Position: refs/heads/master@{#388293}
==========

[commit-bot: I haz the power, 2016-04-22 19:15:42]

Patchset 6 (id:??) landed as
https://crrev.com/d0ecb3bae2d232c17581eed59fe8aa31fa68f96b
Cr-Commit-Position: refs/heads/master@{#388293}