Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1892123002: [mojo-edk] Disable clean shutdown behavior (Closed)

Created:
4 years, 8 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 8 months ago
Reviewers:
sky
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[mojo-edk] Disable clean shutdown behavior Due to the associated bug, we've started encountering (in browser tests) situations where a process has outstanding proxy ports that never get cleaned up. This results in clean shutdown never being possible. This CL disables clean shutdown behavior until the root of the bug is fixed. Note that this may introduce other subtle failures, because without clean shutdown, a process may exit immediately after transferring a pipe endpoint elsewhere. This can result in a broken pipe. BUG=589864 TBR=amistry@chromium.org Committed: https://crrev.com/d59d182178cf4fdbb493869a871c80661c98e80b Cr-Commit-Position: refs/heads/master@{#387615}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M mojo/edk/system/node_controller.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Ken Rockot(use gerrit already)
4 years, 8 months ago (2016-04-15 15:27:00 UTC) #5
sky
LGTM
4 years, 8 months ago (2016-04-15 16:12:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1892123002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1892123002/40001
4 years, 8 months ago (2016-04-15 16:17:09 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 8 months ago (2016-04-15 16:24:19 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 16:25:49 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d59d182178cf4fdbb493869a871c80661c98e80b
Cr-Commit-Position: refs/heads/master@{#387615}

Powered by Google App Engine
This is Rietveld 408576698