Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1892113002: Fix ANGLE in SampleApp (Closed)

Created:
4 years, 8 months ago by Brian Osman
Modified:
4 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix ANGLE in SampleApp Typo in DLL name meant that we were never running with ANGLE. Fixing that exposed problem with attachANGLE -> we weren't filling out attachment info after the first call, resulting in invalid surface descriptions on windowSizeChanged events. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1892113002 Committed: https://skia.googlesource.com/skia/+/7a9b9aff1a7706abf5245008814e2e38a2c90f1f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -13 lines) Patch
M src/views/win/SkOSWindow_win.cpp View 2 chunks +12 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Brian Osman
4 years, 8 months ago (2016-04-15 14:57:39 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1892113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1892113002/1
4 years, 8 months ago (2016-04-15 14:59:13 UTC) #5
robertphillips
lgtm
4 years, 8 months ago (2016-04-15 15:01:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1892113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1892113002/1
4 years, 8 months ago (2016-04-15 15:02:33 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 15:14:00 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7a9b9aff1a7706abf5245008814e2e38a2c90f1f

Powered by Google App Engine
This is Rietveld 408576698