third_party/WebKit/LayoutTests/fast/dom/Window/resources/window-property-collector.js - Issue 1892083002: Generic Sensor API : Ambient Light Sensor API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/Window/resources/window-property-collector.js

Issue 1892083002: Generic Sensor API : Ambient Light Sensor API. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: re entrancy fix Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt ('k') | third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/dom/Window/resources/window-property-collector.js

diff --git a/third_party/WebKit/LayoutTests/fast/dom/Window/resources/window-property-collector.js b/third_party/WebKit/LayoutTests/fast/dom/Window/resources/window-property-collector.js

index 5cbd31604727f7d460aacdc363de3862d429c387..7625322e34ff857986664cb10bfee8db98feef93 100644

--- a/third_party/WebKit/LayoutTests/fast/dom/Window/resources/window-property-collector.js

+++ b/third_party/WebKit/LayoutTests/fast/dom/Window/resources/window-property-collector.js

@@ -50,6 +50,10 @@ function emitExpectedResult(path, expected)

if (propertyPath == 'navigator.connection.downlinkMax')

return;

+ // Skip some lightSensor properties.

+ if (propertyPath == 'navigator.lightSensor.reading.illuminance' || propertyPath == 'navigator.lightSensor.state')

+ return;

switch (propertyPath) {

case "location.href":

expected = "'about:blank'";