Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
Side by Side Diff: third_party/WebKit/Source/modules/sensor/OWNERS
Issue
1892083002
:
Generic Sensor API : Ambient Light Sensor API.
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: re entrancy fix
Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
content/browser/BUILD.gn
content/browser/DEPS
content/browser/renderer_host/render_process_host_impl.cc
content/content.gyp
content/content_browser.gypi
content/content_renderer.gypi
content/public/android/BUILD.gn
content/public/android/java/src/org/chromium/content/browser/ServiceRegistrar.java
content/renderer/BUILD.gn
device/sensor/BUILD.gn
device/sensor/OWNERS
device/sensor/als_reading.mojom
device/sensor/android/BUILD.gn
device/sensor/android/java/src/org/chromium/device/sensor/AmbientLightSensorImpl.java
device/sensor/sensor.gyp
device/sensor/sensor.mojom
device/sensor/sensor_export.h
device/sensor/sensor_impl.h
device/sensor/sensor_impl.cc
device/sensor/sensor_manager.h
device/sensor/sensor_manager_default.cc
device/sensor/sensor_service.h
device/sensor/sensor_service.cc
third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt
third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt
third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt
third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt
third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt
third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt
third_party/WebKit/LayoutTests/fast/dom/Window/resources/window-property-collector.js
third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
third_party/WebKit/Source/core/frame/UseCounter.h
third_party/WebKit/Source/modules/BUILD.gn
third_party/WebKit/Source/modules/EventTargetModulesFactory.in
third_party/WebKit/Source/modules/modules.gyp
third_party/WebKit/Source/modules/modules.gypi
third_party/WebKit/Source/modules/sensor/AmbientLightSensor.h
third_party/WebKit/Source/modules/sensor/AmbientLightSensor.cpp
third_party/WebKit/Source/modules/sensor/AmbientLightSensor.idl
third_party/WebKit/Source/modules/sensor/AmbientLightSensorDispatcher.h
third_party/WebKit/Source/modules/sensor/AmbientLightSensorDispatcher.cpp
third_party/WebKit/Source/modules/sensor/AmbientLightSensorReading.h
third_party/WebKit/Source/modules/sensor/AmbientLightSensorReading.cpp
third_party/WebKit/Source/modules/sensor/AmbientLightSensorReading.idl
third_party/WebKit/Source/modules/sensor/DEPS
third_party/WebKit/Source/modules/sensor/NavigatorAmbientLightSensor.h
third_party/WebKit/Source/modules/sensor/NavigatorAmbientLightSensor.cpp
third_party/WebKit/Source/modules/sensor/NavigatorAmbientLightSensor.idl
third_party/WebKit/Source/modules/sensor/OWNERS
third_party/WebKit/Source/modules/sensor/Sensor.h
third_party/WebKit/Source/modules/sensor/Sensor.cpp
third_party/WebKit/Source/modules/sensor/Sensor.idl
third_party/WebKit/Source/modules/sensor/SensorErrorEvent.h
third_party/WebKit/Source/modules/sensor/SensorErrorEvent.cpp
third_party/WebKit/Source/modules/sensor/SensorErrorEvent.idl
third_party/WebKit/Source/modules/sensor/SensorErrorEventInit.idl
third_party/WebKit/Source/modules/sensor/SensorOptions.idl
third_party/WebKit/Source/modules/sensor/SensorReading.h
third_party/WebKit/Source/modules/sensor/SensorReading.cpp
third_party/WebKit/Source/modules/sensor/SensorReading.idl
third_party/WebKit/Source/modules/sensor/SensorReadingEvent.h
third_party/WebKit/Source/modules/sensor/SensorReadingEvent.cpp
third_party/WebKit/Source/modules/sensor/SensorReadingEvent.idl
third_party/WebKit/Source/modules/sensor/SensorReadingEventInit.idl
third_party/WebKit/Source/modules/sensor/SensorState.h
third_party/WebKit/Source/modules/sensor/als_reading.h
third_party/WebKit/Source/modules/sensor/sensor_error_type.h
third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
tools/metrics/histograms/histograms.xml
View unified diff
|
« no previous file with comments
|
« third_party/WebKit/Source/modules/sensor/NavigatorAmbientLightSensor.idl
('k') |
third_party/WebKit/Source/modules/sensor/Sensor.h »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
rijubrata.bhaumik@intel.com
2
timvolodine@chromium.org
OLD
NEW
« no previous file with comments
|
« third_party/WebKit/Source/modules/sensor/NavigatorAmbientLightSensor.idl
('k') |
third_party/WebKit/Source/modules/sensor/Sensor.h »
('j') |
no next file with comments »
Issue 1892083002: Generic Sensor API : Ambient Light Sensor API.
Created 4 years, 8 months ago by riju_
Modified 4 years, 7 months ago
Reviewers: timvolodine
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 9
Chromium Code Reviews