Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3164)

Unified Diff: base/task_scheduler/scheduler_thread_pool.h

Issue 1892033003: TaskScheduler [10] SchedulerWorkerThreadStack (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@9_single_thread
Patch Set: CR danakj #44 (Empty -> IsEmpty) Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/base.gypi ('k') | base/task_scheduler/scheduler_thread_pool.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/task_scheduler/scheduler_thread_pool.h
diff --git a/base/task_scheduler/scheduler_thread_pool.h b/base/task_scheduler/scheduler_thread_pool.h
index 75c8a3290cfbc2cb9c2a60a6a40ef8510a841b13..7afdd990854e155e009fa6a50e9f330de49305b1 100644
--- a/base/task_scheduler/scheduler_thread_pool.h
+++ b/base/task_scheduler/scheduler_thread_pool.h
@@ -8,7 +8,6 @@
#include <stddef.h>
#include <memory>
-#include <stack>
#include <vector>
#include "base/base_export.h"
@@ -21,6 +20,7 @@
#include "base/task_scheduler/scheduler_lock.h"
#include "base/task_scheduler/scheduler_task_executor.h"
#include "base/task_scheduler/scheduler_worker_thread.h"
+#include "base/task_scheduler/scheduler_worker_thread_stack.h"
#include "base/task_scheduler/sequence.h"
#include "base/task_scheduler/task.h"
#include "base/task_scheduler/task_traits.h"
@@ -97,10 +97,6 @@ class BASE_EXPORT SchedulerThreadPool : public SchedulerTaskExecutor {
// Adds |worker_thread| to |idle_worker_threads_stack_|.
void AddToIdleWorkerThreadsStack(SchedulerWorkerThread* worker_thread);
- // Pops one idle worker thread from |idle_worker_thread_stack_| and returns
- // it. Returns nullptr if |idle_worker_thread_stack_| is empty.
- SchedulerWorkerThread* PopOneIdleWorkerThread();
-
// PriorityQueue from which all threads of this thread pool get work.
PriorityQueue shared_priority_queue_;
@@ -116,7 +112,7 @@ class BASE_EXPORT SchedulerThreadPool : public SchedulerTaskExecutor {
SchedulerLock idle_worker_threads_stack_lock_;
// Stack of idle worker threads.
- std::stack<SchedulerWorkerThread*> idle_worker_threads_stack_;
+ SchedulerWorkerThreadStack idle_worker_threads_stack_;
// Signaled when all worker threads become idle.
std::unique_ptr<ConditionVariable> idle_worker_threads_stack_cv_for_testing_;
« no previous file with comments | « base/base.gypi ('k') | base/task_scheduler/scheduler_thread_pool.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698