Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1003)

Unified Diff: base/task_scheduler/scheduler_thread_pool.h

Issue 1892033003: TaskScheduler [10] SchedulerWorkerThreadStack (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@9_single_thread
Patch Set: CR gab (improve comment) Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/task_scheduler/scheduler_thread_pool.h
diff --git a/base/task_scheduler/scheduler_thread_pool.h b/base/task_scheduler/scheduler_thread_pool.h
index 75c8a3290cfbc2cb9c2a60a6a40ef8510a841b13..df37841d3302cd9c813b46e28fb27fb16de11213 100644
--- a/base/task_scheduler/scheduler_thread_pool.h
+++ b/base/task_scheduler/scheduler_thread_pool.h
@@ -8,7 +8,6 @@
#include <stddef.h>
#include <memory>
-#include <stack>
#include <vector>
#include "base/base_export.h"
@@ -20,6 +19,7 @@
#include "base/task_scheduler/priority_queue.h"
#include "base/task_scheduler/scheduler_lock.h"
#include "base/task_scheduler/scheduler_task_executor.h"
+#include "base/task_scheduler/scheduler_unique_stack.h"
#include "base/task_scheduler/scheduler_worker_thread.h"
#include "base/task_scheduler/sequence.h"
#include "base/task_scheduler/task.h"
@@ -116,7 +116,7 @@ class BASE_EXPORT SchedulerThreadPool : public SchedulerTaskExecutor {
SchedulerLock idle_worker_threads_stack_lock_;
// Stack of idle worker threads.
- std::stack<SchedulerWorkerThread*> idle_worker_threads_stack_;
+ SchedulerUniqueStack<SchedulerWorkerThread*> idle_worker_threads_stack_;
// Signaled when all worker threads become idle.
std::unique_ptr<ConditionVariable> idle_worker_threads_stack_cv_for_testing_;

Powered by Google App Engine
This is Rietveld 408576698