Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Unified Diff: base/task_scheduler/scheduler_stack_unittest.cc

Issue 1892033003: TaskScheduler [10] SchedulerWorkerThreadStack (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@9_single_thread
Patch Set: use bitfield to determine whether an element is on the stack Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/task_scheduler/scheduler_stack_unittest.cc
diff --git a/base/task_scheduler/scheduler_stack_unittest.cc b/base/task_scheduler/scheduler_stack_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..bc9ed8dad68dbdc3f74bfb699b80ee4492a82462
--- /dev/null
+++ b/base/task_scheduler/scheduler_stack_unittest.cc
@@ -0,0 +1,154 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/task_scheduler/scheduler_stack.h"
+
+#include "base/task_scheduler/test_utils.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace base {
+namespace internal {
+
+// Verify that Push() and Pop() add/remove values in FIFO order.
+TEST(TaskSchedulerStackTest, PushPop) {
+ SchedulerStack stack;
+ EXPECT_TRUE(stack.Empty());
+ EXPECT_EQ(0U, stack.Size());
+
+ stack.Push(1);
+ EXPECT_FALSE(stack.Empty());
+ EXPECT_EQ(1U, stack.Size());
+
+ stack.Push(2);
+ EXPECT_FALSE(stack.Empty());
+ EXPECT_EQ(2U, stack.Size());
+
+ stack.Push(3);
+ EXPECT_FALSE(stack.Empty());
+ EXPECT_EQ(3U, stack.Size());
+
+ EXPECT_EQ(3, stack.Pop());
+ EXPECT_FALSE(stack.Empty());
+ EXPECT_EQ(2U, stack.Size());
+
+ stack.Push(3);
+ EXPECT_FALSE(stack.Empty());
+ EXPECT_EQ(3U, stack.Size());
+
+ EXPECT_EQ(3, stack.Pop());
+ EXPECT_FALSE(stack.Empty());
+ EXPECT_EQ(2U, stack.Size());
+
+ EXPECT_EQ(2, stack.Pop());
+ EXPECT_FALSE(stack.Empty());
+ EXPECT_EQ(1U, stack.Size());
+
+ EXPECT_EQ(1, stack.Pop());
+ EXPECT_TRUE(stack.Empty());
+ EXPECT_EQ(0U, stack.Size());
+}
+
+// Verify that all elements in [0, 63] can be pushed and popped from the stack.
+TEST(TaskSchedulerStackTest, PushPopAllRange) {
+ SchedulerStack stack;
+ EXPECT_EQ(0, stack.Size());
+
+ for (int i = 0; i <= 63; ++i) {
+ stack.Push(i);
+ EXPECT_EQ(i + 1, stack.Size());
+ }
+
+ for (int i = 63; i >= 0; --i) {
+ EXPECT_EQ(i, stack.Pop());
+ EXPECT_EQ(i, stack.Size());
+ }
+}
+
+// Verify that a value can be removed by Remove().
+TEST(TaskSchedulerStackTest, Remove) {
+ SchedulerStack stack;
+ EXPECT_TRUE(stack.Empty());
+ EXPECT_EQ(0U, stack.Size());
+
+ stack.Push(1);
+ EXPECT_FALSE(stack.Empty());
+ EXPECT_EQ(1U, stack.Size());
+
+ stack.Push(2);
+ EXPECT_FALSE(stack.Empty());
+ EXPECT_EQ(2U, stack.Size());
+
+ stack.Push(3);
+ EXPECT_FALSE(stack.Empty());
+ EXPECT_EQ(3U, stack.Size());
+
+ stack.Remove(2);
+ EXPECT_FALSE(stack.Empty());
+ EXPECT_EQ(2U, stack.Size());
+
+ EXPECT_EQ(3, stack.Pop());
+ EXPECT_FALSE(stack.Empty());
+ EXPECT_EQ(1U, stack.Size());
+
+ EXPECT_EQ(1, stack.Pop());
+ EXPECT_TRUE(stack.Empty());
+ EXPECT_EQ(0U, stack.Size());
+}
+
+// Verify that all elements in [0, 63] can be pushed and removed from the stack.
+TEST(TaskSchedulerStackTest, PushRemoveAllRange) {
+ SchedulerStack stack;
+ EXPECT_EQ(0, stack.Size());
+
+ for (int i = 0; i <= 63; ++i) {
+ stack.Push(i);
+ EXPECT_EQ(i + 1, stack.Size());
+ }
+
+ for (int i = 63; i >= 0; --i) {
gab 2016/04/18 18:35:40 Remove in increasing order to test that it works i
fdoray 2016/04/18 20:33:12 Done.
+ stack.Remove(i);
+ EXPECT_EQ(i, stack.Size());
+ }
+}
+
+// Verify that a value can be pushed again after it has been removed.
+TEST(TaskSchedulerStackTest, PushAfterRemove) {
+ SchedulerStack stack;
+ EXPECT_EQ(0U, stack.Size());
+ EXPECT_TRUE(stack.Empty());
+
+ stack.Push(5);
+ EXPECT_EQ(1U, stack.Size());
+ EXPECT_FALSE(stack.Empty());
+
+ stack.Remove(5);
+ EXPECT_EQ(0U, stack.Size());
+ EXPECT_TRUE(stack.Empty());
+
+ stack.Push(5);
+ EXPECT_EQ(1U, stack.Size());
+ EXPECT_FALSE(stack.Empty());
+}
+
+// Verify that Push() DCHECKs when a value under the allowed range is inserted.
+TEST(TaskSchedulerStackTest, PushUnderAllowedRange) {
+ SchedulerStack stack;
+ EXPECT_DCHECK_DEATH({ stack.Push(-1); }, "");
+}
+
+// Verify that Push() DCHECKs when a value above the allowed range is inserted.
+TEST(TaskSchedulerStackTest, PushAboveAllowedRange) {
+ SchedulerStack stack;
+ EXPECT_DCHECK_DEATH({ stack.Push(64); }, "");
+}
+
+// Verify that Push() DCHECKs when a value is inserted twice.
+TEST(TaskSchedulerStackTest, PushTwice) {
+ SchedulerStack stack;
+ stack.Push(5);
+ EXPECT_DCHECK_DEATH({ stack.Push(5); }, "");
+}
+
+} // namespace internal
+} // namespace base
« base/task_scheduler/scheduler_stack.cc ('K') | « base/task_scheduler/scheduler_stack.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698