net/cert/multi_threaded_cert_verifier_unittest.cc - Issue 1892033002: Cert - protobufs to serialize and deserialize CertVerifierCache.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/multi_threaded_cert_verifier_unittest.cc

Issue 1892033002: Cert - protobufs to serialize and deserialize CertVerifierCache. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: delete scoped_ptr and use unique_ptr Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/cert/multi_threaded_cert_verifier.h ('K') | « net/cert/multi_threaded_cert_verifier.cc ('k') | net/cert/proto/cert_verification.proto » ('j') | net/cert/proto/cert_verification.proto » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/cert/multi_threaded_cert_verifier_unittest.cc

diff --git a/net/cert/multi_threaded_cert_verifier_unittest.cc b/net/cert/multi_threaded_cert_verifier_unittest.cc

index 0704a13c3235e961c1750f9bc879ed7e6c7ba375..e09e1276b088be416d1ac4c37f4528927332a382 100644

--- a/net/cert/multi_threaded_cert_verifier_unittest.cc

+++ b/net/cert/multi_threaded_cert_verifier_unittest.cc

@@ -112,6 +112,11 @@ TEST_F(MultiThreadedCertVerifierTest, CacheHit) {

ASSERT_EQ(1u, verifier_.cache_hits());

ASSERT_EQ(0u, verifier_.inflight_joins());

ASSERT_EQ(1u, verifier_.GetCacheSize());

+ CertVerifierCacheIterator iterator(verifier_);

+ EXPECT_TRUE(iterator.HasNext());

+ ASSERT_EQ("www.example.com", iterator.hostname());

+ iterator.Advance();

+ EXPECT_FALSE(iterator.HasNext());

Ryan Sleevi 2016/04/29 23:33:21 No. Please add a new test.

ramant (doing other things) 2016/04/30 22:58:11 Done.

}

// Tests the same server certificate with different intermediate CA