Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 1892013003: Use platform specific test results as fallback in difference tests (Closed)

Created:
4 years, 8 months ago by Wei Li
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Use platform specific test results as fallback in difference tests So far, we have only two Windows tests require to use platform specific test results due to platform idiosyncracies. However, VS2015 has fixed those issues. So in general, We only need to use platform based results if checking against the regular results failed. Committed: https://pdfium.googlesource.com/pdfium/+/c3b26b1479824aa5ce745c220a82de7528bc26a9

Patch Set 1 : #

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -7 lines) Patch
M testing/tools/pngdiffer.py View 1 1 chunk +18 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Wei Li
PTAL, thanks
4 years, 8 months ago (2016-04-15 16:18:45 UTC) #3
Tom Sepez
we should probably just do the same on all ports, namely, try the "generic" result, ...
4 years, 8 months ago (2016-04-15 16:32:32 UTC) #4
Wei Li
On 2016/04/15 16:32:32, Tom Sepez wrote: > we should probably just do the same on ...
4 years, 8 months ago (2016-04-15 17:43:43 UTC) #5
Tom Sepez
lgtm
4 years, 8 months ago (2016-04-15 18:45:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1892013003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1892013003/40001
4 years, 8 months ago (2016-04-15 18:49:59 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 19:03:05 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/c3b26b1479824aa5ce745c220a82de7528bc...

Powered by Google App Engine
This is Rietveld 408576698