ReleaseOutputBuffer to surface back and front buffers where possible.

content/common/gpu/media/android_deferred_rendering_backing_strategy.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/gpu/media/android_deferred_rendering_backing_strategy.h"
 
 #include <EGL/egl.h>
 #include <EGL/eglext.h>
 
 #include "base/android/build_info.h"
@@ skipping 159 matching lines @@
     int32_t codec_buf_index,
     const media::PictureBuffer& picture_buffer) {
   // Make sure that the decoder is available.
   RETURN_IF_NULL(state_provider_->GetGlDecoder());
 
   // Notify the AVDACodecImage for picture_buffer that it should use the
   // decoded buffer codec_buf_index to render this frame.
   AVDACodecImage* avda_image =
       shared_state_->GetImageForPicture(picture_buffer.id());
   RETURN_IF_NULL(avda_image);
-  DCHECK_EQ(avda_image->GetMediaCodecBufferIndex(), -1);
+
   // Note that this is not a race, since we do not re-use a PictureBuffer
   // until after the CC is done drawing it.
+  pictures_out_for_display_.push_back(picture_buffer.id());
   avda_image->SetMediaCodecBufferIndex(codec_buf_index);
   avda_image->SetSize(state_provider_->GetSize());
+
+  MaybeRenderEarly();
 }
 
 void AndroidDeferredRenderingBackingStrategy::AssignOnePictureBuffer(
     const media::PictureBuffer& picture_buffer,
     bool have_context) {
   // Attach a GLImage to each texture that will use the surface texture.
   // We use a refptr here in case SetImageForPicture fails.
   scoped_refptr<gpu::gles2::GLStreamTextureImage> gl_image =
       new AVDACodecImage(picture_buffer.id(), shared_state_, media_codec_,
                          state_provider_->GetGlDecoder(), surface_texture_);
@@ skipping 14 matching lines @@
     glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, size.width(), size.height(), 0,
                  GL_RGBA, GL_UNSIGNED_BYTE, rgba);
   }
 }
 
 void AndroidDeferredRenderingBackingStrategy::ReleaseCodecBufferForPicture(
     const media::PictureBuffer& picture_buffer) {
   AVDACodecImage* avda_image =
       shared_state_->GetImageForPicture(picture_buffer.id());
   RETURN_IF_NULL(avda_image);
-
-  // See if there is a media codec buffer still attached to this image.
-  const int32_t codec_buffer = avda_image->GetMediaCodecBufferIndex();
-
-  if (codec_buffer >= 0) {
-    // PictureBuffer wasn't displayed, so release the buffer.
-    media_codec_->ReleaseOutputBuffer(codec_buffer, false);
-    avda_image->SetMediaCodecBufferIndex(-1);
-  }
+  avda_image->UpdateSurface(AVDACodecImage::UpdateMode::DISCARD_CODEC_BUFFER);
 }
 
 void AndroidDeferredRenderingBackingStrategy::ReuseOnePictureBuffer(
     const media::PictureBuffer& picture_buffer) {
+  pictures_out_for_display_.erase(
+      std::remove(pictures_out_for_display_.begin(),

[liberato (no reviews please), 2016/04/22 20:25:08]

i don't understand what this does.  std::remove() will return an iterator to
something that is not |id|.  ::erase will erase it.

also not sure why erasing to the end is a good idea.  isn't that the newest
frame?  wouldn't one want to erase from the beginning?  would one want to erase
a whole range?  i actually think that one would not.

it's fairly common that i get stl iterators wrong, though, so maybe i'm just
doing that here too.

[DaleCurtis, 2016/04/22 20:58:02]

https://en.wikipedia.org/wiki/Erase%E2%80%93remove_idiom

std::remove() rotates the element(s) to be erased to the end of the vector and
then .erase() removes the end of the range (which is all to-be-deleted elements)

+                  pictures_out_for_display_.end(), picture_buffer.id()),
+      pictures_out_for_display_.end());
+
   // At this point, the CC must be done with the picture.  We can't really
   // check for that here directly.  it's guaranteed in gpu_video_decoder.cc,
   // when it waits on the sync point before releasing the mailbox.  That sync
   // point is inserted by destroying the resource in VideoLayerImpl::DidDraw.
   ReleaseCodecBufferForPicture(picture_buffer);
+  MaybeRenderEarly();
+}
+
+void AndroidDeferredRenderingBackingStrategy::MaybeRenderEarly() {
+  // See if we can consume the front buffer / render to the SurfaceView.
+  if (pictures_out_for_display_.size() == 1u) {
+    AVDACodecImage* avda_image =
+        shared_state_->GetImageForPicture(*pictures_out_for_display_.begin());
+    RETURN_IF_NULL(avda_image);
+    avda_image->UpdateSurface(
+        AVDACodecImage::UpdateMode::RENDER_TO_FRONT_BUFFER);
+    return;
+  }
+
+  // Back buffer rendering is only available for surface textures.
+  if (!surface_texture_)
+    return;
+
+  // See if the back buffer is free. If so, then render the earliest frame.  The
+  // listing is in render order, so we can just use the first unrendered frame
+  // if there is back buffer space.
+  AVDACodecImage* first_renderable_image = nullptr;
+  for (int id : pictures_out_for_display_) {
+    AVDACodecImage* avda_image = shared_state_->GetImageForPicture(id);
+    if (!avda_image)
+      continue;
+
+    // If the back buffer is unavailable, there's nothing left to do.
+    if (avda_image->is_rendered_to_back_buffer())
+      return;
+
+    // If the image is rendered to the front buffer or has been dropped, it is
+    // not valid for rendering.
+    if (avda_image->is_rendered())
+      continue;
+
+    if (!first_renderable_image)
+      first_renderable_image = avda_image;
+  }
+
+  if (first_renderable_image) {
+    first_renderable_image->UpdateSurface(
+        AVDACodecImage::UpdateMode::RENDER_TO_BACK_BUFFER);
+  }
 }
 
 void AndroidDeferredRenderingBackingStrategy::CodecChanged(
     media::VideoCodecBridge* codec) {
   media_codec_ = codec;
   shared_state_->CodecChanged(codec);
 }
 
 void AndroidDeferredRenderingBackingStrategy::OnFrameAvailable() {
   shared_state_->SignalFrameAvailable();
@@ skipping 134 matching lines @@
           return !feature_info->workarounds().avda_dont_copy_pictures;
       }
     }
   }
 
   // Assume so.
   return true;
 }
 
 }  // namespace content