Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1891963002: MD Settings: Replace paper-menu with paper-listbox in a few places. (Closed)

Created:
4 years, 8 months ago by dpapad
Modified:
4 years, 8 months ago
Reviewers:
michaelpg
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, dcheng, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Replace paper-menu with paper-listbox in a few places. BUG=601214 Committed: https://crrev.com/67a46787976d0cddf54793b2561e258a7c940e79 Cr-Commit-Position: refs/heads/master@{#387510}

Patch Set 1 #

Patch Set 2 : More #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M chrome/browser/resources/settings/controls/settings_dropdown_menu.html View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/site_details_permission.html View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/data/webui/settings/dropdown_menu_tests.js View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dpapad
4 years, 8 months ago (2016-04-14 23:09:06 UTC) #3
michaelpg
lgtm
4 years, 8 months ago (2016-04-14 23:38:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891963002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891963002/60001
4 years, 8 months ago (2016-04-15 00:42:27 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-15 01:21:25 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 01:25:17 UTC) #9
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/67a46787976d0cddf54793b2561e258a7c940e79
Cr-Commit-Position: refs/heads/master@{#387510}

Powered by Google App Engine
This is Rietveld 408576698