Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1891953002: Avoid needless construction of CFX_ByteStrings during string building (Closed)

Created:
4 years, 8 months ago by Tom Sepez
Modified:
4 years, 8 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Avoid needless construction of CFX_ByteStrings during string building There are perfectly fine operators for adding to an existing string without first duplicating the arguments. Committed: https://pdfium.googlesource.com/pdfium/+/ff242e0b62173718a6e98aee1306ac48f6372572

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M core/fpdfdoc/doc_utils.cpp View 3 chunks +16 lines, -16 lines 0 comments Download
M xfa/fxbarcode/pdf417/BC_PDF417DetectionResultRowIndicatorColumn.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Tom Sepez
Lei, for review.
4 years, 8 months ago (2016-04-14 21:21:31 UTC) #2
Lei Zhang
lgtm
4 years, 8 months ago (2016-04-14 21:34:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891953002/1
4 years, 8 months ago (2016-04-14 21:39:01 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 21:55:02 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/ff242e0b62173718a6e98aee1306ac48f637...

Powered by Google App Engine
This is Rietveld 408576698