Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Unified Diff: components/metrics/metrics_service.cc

Issue 1891913002: Support saving browser metrics to disk and reading them during next run. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removed some unnecessary includes Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/metrics/metrics_provider.cc ('k') | content/browser/browser_main_runner.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/metrics/metrics_service.cc
diff --git a/components/metrics/metrics_service.cc b/components/metrics/metrics_service.cc
index 7e31ddb93156bf301ef333bd5cbe71bb7acc9691..41cdec833c58ecd38c5e4618780edc2e84167751 100644
--- a/components/metrics/metrics_service.cc
+++ b/components/metrics/metrics_service.cc
@@ -1143,11 +1143,9 @@ void MetricsService::RecordCurrentHistograms() {
histogram_snapshot_manager_.StartDeltas();
// "true" to the begin() call indicates that StatisticsRecorder should include
// histograms held in persistent storage.
- auto end = base::StatisticsRecorder::end();
- for (auto it = base::StatisticsRecorder::begin(true); it != end; ++it) {
- if ((*it)->flags() & base::Histogram::kUmaTargetedHistogramFlag)
- histogram_snapshot_manager_.PrepareDelta(*it);
- }
+ histogram_snapshot_manager_.PrepareDeltasWithoutStartFinish(
+ base::StatisticsRecorder::begin(true), base::StatisticsRecorder::end(),
+ base::Histogram::kNoFlags, base::Histogram::kUmaTargetedHistogramFlag);
for (MetricsProvider* provider : metrics_providers_)
provider->RecordHistogramSnapshots(&histogram_snapshot_manager_);
histogram_snapshot_manager_.FinishDeltas();
@@ -1155,11 +1153,15 @@ void MetricsService::RecordCurrentHistograms() {
void MetricsService::RecordCurrentStabilityHistograms() {
DCHECK(log_manager_.current_log());
+ histogram_snapshot_manager_.StartDeltas();
// "true" indicates that StatisticsRecorder should include histograms in
// persistent storage.
- histogram_snapshot_manager_.PrepareDeltas(
+ histogram_snapshot_manager_.PrepareDeltasWithoutStartFinish(
base::StatisticsRecorder::begin(true), base::StatisticsRecorder::end(),
base::Histogram::kNoFlags, base::Histogram::kUmaStabilityHistogramFlag);
+ for (MetricsProvider* provider : metrics_providers_)
+ provider->RecordInitialHistogramSnapshots(&histogram_snapshot_manager_);
+ histogram_snapshot_manager_.FinishDeltas();
}
void MetricsService::LogCleanShutdown() {
« no previous file with comments | « components/metrics/metrics_provider.cc ('k') | content/browser/browser_main_runner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698