Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Unified Diff: components/metrics/file_metrics_provider.cc

Issue 1891913002: Support saving browser metrics to disk and reading them during next run. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed some build problems Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/file_metrics_provider.cc
diff --git a/components/metrics/file_metrics_provider.cc b/components/metrics/file_metrics_provider.cc
index 78fb90a1211c5f6b4e69330517e4197aef496c58..ee9ec22c06b7a7879b6fb8fe86674c3c61a74537 100644
--- a/components/metrics/file_metrics_provider.cc
+++ b/components/metrics/file_metrics_provider.cc
@@ -183,7 +183,7 @@ void FileMetricsProvider::RecordHistogramSnapshotsFromFile(
if (!histogram)
break;
if (file->type == FILE_HISTOGRAMS_ATOMIC)
- snapshot_manager->PrepareAbsoluteTakingOwnership(std::move(histogram));
+ snapshot_manager->PrepareDifferenceTakingOwnership(std::move(histogram));
Ilya Sherman 2016/04/19 00:57:46 So, why is it important here that we take the (ide
bcwhite 2016/04/19 16:33:38 Because in some situations, the data may be read-o
Ilya Sherman 2016/04/20 07:12:14 I'd prefer to back-out the PrepareDifference chang
bcwhite 2016/04/20 16:47:45 Done.
else
snapshot_manager->PrepareDeltaTakingOwnership(std::move(histogram));
++histogram_count;

Powered by Google App Engine
This is Rietveld 408576698