components/metrics/file_metrics_provider.cc - Issue 1891913002: Support saving browser metrics to disk and reading them during next run.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/file_metrics_provider.cc

Issue 1891913002: Support saving browser metrics to disk and reading them during next run. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed review comments by Ilya Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/metrics/persistent_histogram_allocator.cc ('K') | « chrome/browser/metrics/chrome_metrics_service_client.cc ('k') | content/browser/browser_main_runner.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/metrics/file_metrics_provider.cc

diff --git a/components/metrics/file_metrics_provider.cc b/components/metrics/file_metrics_provider.cc

index 36a60df799006f9684477f5f63ce7be256ed5948..65284556c7dbbdb3147823e83134d238179209b3 100644

--- a/components/metrics/file_metrics_provider.cc

+++ b/components/metrics/file_metrics_provider.cc

@@ -185,10 +185,11 @@ void FileMetricsProvider::RecordHistogramSnapshotsFromFile(

scoped_ptr<base::HistogramBase> histogram = histogram_iter.GetNext();

if (!histogram)

break;

- if (file->type == FILE_HISTOGRAMS_ATOMIC)

- snapshot_manager->PrepareAbsoluteTakingOwnership(std::move(histogram));

- else

- snapshot_manager->PrepareDeltaTakingOwnership(std::move(histogram));

+ // The "delta" is calculated, which updates the "logged" counts, even

+ // for "atomic" files that may be read-only. This is possible because

+ // the file contents are copied into read/write memory which is then

+ // discarded after the reporting is complete.

+ snapshot_manager->PrepareDeltaTakingOwnership(std::move(histogram));

++histogram_count;

}