Support saving browser metrics to disk and reading them during next run.

components/metrics/metrics_service.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 //------------------------------------------------------------------------------
 // Description of the life cycle of a instance of MetricsService.
 //
 //  OVERVIEW
 //
 // A MetricsService instance is typically created at application startup.  It is
@@ skipping 1137 matching lines @@
     if ((*it)->flags() & base::Histogram::kUmaTargetedHistogramFlag)
       histogram_snapshot_manager_.PrepareDelta(*it);
   }
   for (MetricsProvider* provider : metrics_providers_)
     provider->RecordHistogramSnapshots(&histogram_snapshot_manager_);
   histogram_snapshot_manager_.FinishDeltas();
 }
 
 void MetricsService::RecordCurrentStabilityHistograms() {
   DCHECK(log_manager_.current_log());
+  histogram_snapshot_manager_.StartDeltas();
   // "true" indicates that StatisticsRecorder should include histograms in
   // persistent storage.
-  histogram_snapshot_manager_.PrepareDeltas(
-      base::StatisticsRecorder::begin(true), base::StatisticsRecorder::end(),
-      base::Histogram::kNoFlags, base::Histogram::kUmaStabilityHistogramFlag);
+  for (auto it = base::StatisticsRecorder::begin(true),
+            end = base::StatisticsRecorder::end();
+       it != end; ++it) {

[Ilya Sherman, 2016/05/05 22:22:52]

nit: Why not just write "it != base::StatisticsRecorder::end()"?

[bcwhite, 2016/05/06 16:59:27]

Ah.  Because end() actually has to create a new iterator (which involves
acquiring a lock and creating another end() iterator for the embedded std::map)
so it is best not to do that with each iteration through the loop.

I could change the SR to create the end() iterator during initialization, cache
it, and ever-after just return the cached version.
http://stackoverflow.com/questions/1432216/is-end-required-to-be-constant-in-...

But since the SR keeps all its member variables as static that can be pushed and
popped as more SRs are created (only in tests), the cached end() would require
the same.

So I just cached it in the loop.  :-)

+    if (((*it)->flags() & base::Histogram::kUmaStabilityHistogramFlag) ==
+        base::Histogram::kUmaStabilityHistogramFlag) {

[Ilya Sherman, 2016/05/05 22:22:52]

Optional nit: I personally prefer the style used on line 1148, which omits the
extra == check.

[bcwhite, 2016/05/06 16:59:27]

Me too, but it bites!  This particular kUma...Flag is NOT a single flag but a
merge of two flags.  Thus, omitting the == means matching anything that has at
least one of the bits set which, in this case, matches any
kUmaTargetedHistogramFlag (or: pretty much everything).

Ask me how I discovered this.  Go on...  I dare ya!

I'll add a comment.

+      histogram_snapshot_manager_.PrepareDelta(*it);
+    }
+  }
+  for (MetricsProvider* provider : metrics_providers_)
+    provider->RecordInitialHistogramSnapshots(&histogram_snapshot_manager_);
+  histogram_snapshot_manager_.FinishDeltas();
 }
 
 void MetricsService::LogCleanShutdown() {
   // Redundant setting to assure that we always reset this value at shutdown
   // (and that we don't use some alternate path, and not call LogCleanShutdown).
   clean_shutdown_status_ = CLEANLY_SHUTDOWN;
 
   clean_exit_beacon_.WriteBeaconValue(true);
   RecordCurrentState(local_state_);
   local_state_->SetInteger(prefs::kStabilityExecutionPhase,
@@ skipping 18 matching lines @@
                  base::Time::Now().ToTimeT());
 }
 
 void MetricsService::SkipAndDiscardUpload() {
   log_manager_.DiscardStagedLog();
   scheduler_->UploadCancelled();
   log_upload_in_progress_ = false;
 }
 
 }  // namespace metrics